From 929cba26c2a29ef6a6d59704a756c77341880f7b Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Thu, 27 Mar 2025 18:12:11 -0500 Subject: [PATCH] perf: avoid double map lookup in `WebFrameMain::UpdateRenderFrameHost()` (#46329) perf: avoid double map lookup in WebFrameMain::UpdateRenderFrameHost() Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/browser/api/electron_api_web_frame_main.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/shell/browser/api/electron_api_web_frame_main.cc b/shell/browser/api/electron_api_web_frame_main.cc index a71d82c51a30..3394408e1bd0 100644 --- a/shell/browser/api/electron_api_web_frame_main.cc +++ b/shell/browser/api/electron_api_web_frame_main.cc @@ -193,8 +193,8 @@ void WebFrameMain::UpdateRenderFrameHost(content::RenderFrameHost* rfh) { // Ensure that RFH being swapped in doesn't already exist as its own // WebFrameMain instance. frame_token_ = rfh->GetGlobalFrameToken(); - DCHECK(!GetFrameTokenMap().contains(frame_token_)); - GetFrameTokenMap().emplace(frame_token_, this); + const auto [_, inserted] = GetFrameTokenMap().emplace(frame_token_, this); + DCHECK(inserted); render_frame_disposed_ = false; TeardownMojoConnection();