From 2bb26b30dc459543cce1427ab722b821959b1ac4 Mon Sep 17 00:00:00 2001 From: Zeke Sikelianos Date: Wed, 20 Sep 2017 15:43:42 +0900 Subject: [PATCH 1/3] add CODEOWNERS file --- .github/CODEOWNERS | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 000000000000..25c099e30652 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,16 @@ +# https://help.github.com/articles/about-codeowners/ +# Order is important. The last matching pattern has the most precedence. + +# Everything that falls through the cracks: +* @electron/reviewers + +**browser_view** @electron/browserview +**notification** @electron/notifications +**pdf** @electron/printing +**printing** @electron/printing +**updater** @electron/updater + +default_app/** @electron/docs +docs/** @electron/docs +docs-translations/** @electron/i18n +npm/** @electron/hubbers \ No newline at end of file From d54cb307d5c67a2b88e509cb9bdc70bd16e6e1fc Mon Sep 17 00:00:00 2001 From: Zeke Sikelianos Date: Fri, 22 Sep 2017 11:00:38 +0900 Subject: [PATCH 2/3] do not use globs --- .github/CODEOWNERS | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 25c099e30652..9a78e6f4f534 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,16 +1,20 @@ -# https://help.github.com/articles/about-codeowners/ -# Order is important. The last matching pattern has the most precedence. +# Order is important. The LAST matching pattern has the MOST precedence. +# gitignore style patterns are used, not globs. +# https://help.github.com/articles/about-codeowners +# https://git-scm.com/docs/gitignore # Everything that falls through the cracks: * @electron/reviewers -**browser_view** @electron/browserview -**notification** @electron/notifications -**pdf** @electron/printing -**printing** @electron/printing -**updater** @electron/updater +# filename patterns +*browser_view* @electron/browserview +*notification* @electron/notifications +*pdf* @electron/printing +*printing* @electron/printing +*updater* @electron/updater -default_app/** @electron/docs -docs/** @electron/docs -docs-translations/** @electron/i18n -npm/** @electron/hubbers \ No newline at end of file +# directories +/default_app/ @electron/docs +/docs/ @electron/docs +/docs-translations/ @electron/i18n +/npm/ @electron/hubbers \ No newline at end of file From 750f59cb554b6d47a2e3c933cc0e6528381bce71 Mon Sep 17 00:00:00 2001 From: Zeke Sikelianos Date: Tue, 26 Sep 2017 20:11:41 -0700 Subject: [PATCH 3/3] make the @hubbers team own the .github directory --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 9a78e6f4f534..263dfe1b373f 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -14,6 +14,7 @@ *updater* @electron/updater # directories +/.github/ @electron/hubbers /default_app/ @electron/docs /docs/ @electron/docs /docs-translations/ @electron/i18n