mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

refactor: remove unused C string ToV8() gin converter (#44500)

Browse source
This commit is contained in:
Charles Kerr 2024-11-01 18:11:46 -05:00 • committed by GitHub
parent b985d8eb28
commit 9137d96ef4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/api/electron_api_web_contents.cc
View file

@ -1344,7 +1344,7 @@ content::KeyboardEventProcessingResult WebContents::PreHandleKeyboardEvent(
}
void WebContents::ContentsZoomChange(bool zoom_in) {
Emit("zoom-changed", zoom_in ? "in" : "out");
Emit("zoom-changed", std::string_view{zoom_in ? "in" : "out"});
}
Profile* WebContents::GetProfile() {

8
shell/common/gin_converters/std_converter.h
View file

@ -54,14 +54,6 @@ struct Converter<std::nullptr_t> {
}
};
template <>
struct Converter<const char*> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate, const char* val) {
return v8::String::NewFromUtf8(isolate, val, v8::NewStringType::kNormal)
.ToLocalChecked();
}
};
template <>
struct Converter<char[]> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate, const char* val) {