mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: don't explicitly destroy asar archives (#15734)

Browse source
This commit is contained in:
Jeremy Apthorp 2018-11-19 13:12:41 -08:00 • committed by GitHub
parent ec4212cce1
commit 90d1c0b2b6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
atom/common/api/atom_api_asar.cc
View file

@ -39,8 +39,7 @@ class Archive : public mate::Wrappable<Archive> {
.SetMethod("readdir", &Archive::Readdir) .SetMethod("readdir", &Archive::Readdir)
.SetMethod("realpath", &Archive::Realpath) .SetMethod("realpath", &Archive::Realpath)
.SetMethod("copyFileOut", &Archive::CopyFileOut) .SetMethod("copyFileOut", &Archive::CopyFileOut)
.SetMethod("getFd", &Archive::GetFD) .SetMethod("getFd", &Archive::GetFD);
.SetMethod("destroy", &Archive::Destroy);
} }
protected: protected:
@ -113,9 +112,6 @@ class Archive : public mate::Wrappable<Archive> {
return archive_->GetFD(); return archive_->GetFD();
} }
// Free the resources used by archive.
void Destroy() { archive_.reset(); }
private: private:
std::unique_ptr<asar::Archive> archive_; std::unique_ptr<asar::Archive> archive_;

8
lib/common/asar.js
View file

@ -37,14 +37,6 @@
return newArchive return newArchive
} }
// Clean cache on quit.
process.on('exit', () => {
for (const archive of cachedArchives.values()) {
archive.destroy()
}
cachedArchives.clear()
})
const ASAR_EXTENSION = '.asar' const ASAR_EXTENSION = '.asar'
// Separate asar package's path from full path. // Separate asar package's path from full path.