mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: make StatusIconType an enum class (#36500)

Browse source 
Co-authored-by: Milan Burda <miburda@microsoft.com>
This commit is contained in:
Milan Burda 2022-12-05 09:59:20 +01:00 committed by GitHub
parent 79d2fc9c23
commit 909ee0ed6b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
shell/browser/ui/tray_icon_gtk.cc
View file

@ -30,7 +30,8 @@ gfx::ImageSkia GetBestImageRep(const gfx::ImageSkia& image) {
} // namespace } // namespace
TrayIconGtk::TrayIconGtk() TrayIconGtk::TrayIconGtk()
: status_icon_(new StatusIconLinuxDbus), status_icon_type_(kTypeDbus) { : status_icon_(new StatusIconLinuxDbus),
status_icon_type_(StatusIconType::kDbus) {
status_icon_->SetDelegate(this); status_icon_->SetDelegate(this);
} }
@ -68,11 +69,11 @@ ui::MenuModel* TrayIconGtk::GetMenuModel() const {
void TrayIconGtk::OnImplInitializationFailed() { void TrayIconGtk::OnImplInitializationFailed() {
switch (status_icon_type_) { switch (status_icon_type_) {
case kTypeDbus: case StatusIconType::kDbus:
status_icon_ = nullptr; status_icon_ = nullptr;
status_icon_type_ = kTypeNone; status_icon_type_ = StatusIconType::kNone;
return; return;
case kTypeNone: case StatusIconType::kNone:
NOTREACHED(); NOTREACHED();
} }
} }

6
shell/browser/ui/tray_icon_gtk.h
View file

@ -36,9 +36,9 @@ class TrayIconGtk : public TrayIcon, public ui::StatusIconLinux::Delegate {
void OnImplInitializationFailed() override; void OnImplInitializationFailed() override;
private: private:
enum StatusIconType { enum class StatusIconType {
kTypeDbus, kDbus,
kTypeNone, kNone,
}; };
scoped_refptr<StatusIconLinuxDbus> status_icon_; scoped_refptr<StatusIconLinuxDbus> status_icon_;