mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Add failing spec for writeable command id

Browse source
This commit is contained in:
Kevin Sawicki 2016-06-22 10:06:54 -07:00
parent c6db5f6baa
commit 90600ba653
1 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
spec/api-menu-spec.js
View file

@ -357,10 +357,23 @@ describe('menu module', function () {
}) })
}) })
describe('MenuItem command id', function () {
it('cannot be overwritten', function () {
var item = new MenuItem({
label: 'item'
})
var commandId = item.commandId
assert(commandId != null)
item.commandId = '' + commandId + '-modified'
assert.equal(item.commandId, commandId)
})
})
describe('MenuItem with invalid type', function () { describe('MenuItem with invalid type', function () {
it('throws an exception', function () { it('throws an exception', function () {
assert.throws(function () { assert.throws(function () {
var menu = Menu.buildFromTemplate([ Menu.buildFromTemplate([
{ {
label: 'text', label: 'text',
type: 'not-a-type' type: 'not-a-type'
@ -373,7 +386,7 @@ describe('menu module', function () {
describe('MenuItem with submenu type and missing submenu', function () { describe('MenuItem with submenu type and missing submenu', function () {
it('throws an exception', function () { it('throws an exception', function () {
assert.throws(function () { assert.throws(function () {
var menu = Menu.buildFromTemplate([ Menu.buildFromTemplate([
{ {
label: 'text', label: 'text',
type: 'submenu' type: 'submenu'