mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: update symbol generation logic for all helpers (#19336)

Browse source
This commit is contained in:
Samuel Attard 2019-07-19 08:02:43 -07:00 • committed by Shelley Vohr
parent 6fc648cd25
commit 8fc38ed549
1 changed files with 17 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

25
BUILD.gn
View file

@ -968,13 +968,18 @@ if (is_mac) {
] ]
} }
extract_symbols("electron_helper_syms") { foreach(helper_params, content_mac_helpers) {
binary = "$root_out_dir/$electron_helper_name.app/Contents/MacOS/$electron_helper_name" _helper_target = helper_params[0]
symbol_dir = "$root_out_dir/breakpad_symbols" _helper_bundle_id = helper_params[1]
dsym_file = "$root_out_dir/$electron_helper_name.dSYM/Contents/Resources/DWARF/$electron_helper_name" _helper_suffix = helper_params[2]
deps = [ extract_symbols("electron_helper_syms_${_helper_target}") {
":electron_helper_app", binary = "$root_out_dir/$electron_helper_name${_helper_suffix}.app/Contents/MacOS/$electron_helper_name${_helper_suffix}"
] symbol_dir = "$root_out_dir/breakpad_symbols"
dsym_file = "$root_out_dir/$electron_helper_name${_helper_suffix}.dSYM/Contents/Resources/DWARF/$electron_helper_name${_helper_suffix}"
deps = [
":electron_helper_app_${_helper_target}",
]
}
} }
extract_symbols("electron_app_syms") { extract_symbols("electron_app_syms") {
@ -1018,10 +1023,14 @@ if (is_mac) {
":crashpad_handler_syms", ":crashpad_handler_syms",
":electron_app_syms", ":electron_app_syms",
":electron_framework_syms", ":electron_framework_syms",
":electron_helper_syms",
":swiftshader_egl_syms", ":swiftshader_egl_syms",
":swiftshader_gles_syms", ":swiftshader_gles_syms",
] ]
foreach(helper_params, content_mac_helpers) {
_helper_target = helper_params[0]
deps += [ ":electron_helper_syms_${_helper_target}" ]
}
} }
} else { } else {
group("electron_symbols") { group("electron_symbols") {