mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 2

Really fix unused-variable warnings

Browse source 
I misunderstood how ALLOW_UNUSED is meant to be used. Using a macro like
MSV_WARNING_SUPPRESS() would be nice, but for some reason it isn't working for
me. So now we just manually reference the variable in the code.
This commit is contained in:
Adam Roben 2014-07-07 14:21:40 -04:00
parent 5b2a62627e
commit 8f2a2e19b5
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
brightray/browser/url_request_context_getter.cc
View file

@ -154,8 +154,8 @@ net::URLRequestContext* URLRequestContextGetter::GetURLRequestContext() {
end = protocol_handlers_.end(); it != end; ++it) { end = protocol_handlers_.end(); it != end; ++it) {
bool set_protocol = job_factory->SetProtocolHandler( bool set_protocol = job_factory->SetProtocolHandler(
it->first, it->second.release()); it->first, it->second.release());
ALLOW_UNUSED(set_protocol);
DCHECK(set_protocol); DCHECK(set_protocol);
(void)set_protocol; // silence unused-variable warning in Release builds on Windows
} }
protocol_handlers_.clear(); protocol_handlers_.clear();
job_factory->SetProtocolHandler( job_factory->SetProtocolHandler(