mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

test: re-enable desktop specs (#33497)

Browse source
This commit is contained in:
Shelley Vohr 2022-03-29 17:57:21 +02:00 committed by GitHub
parent f0c22a770d
commit 8ea0631b82
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
spec-main/api-desktop-capturer-spec.ts
View file

@ -23,8 +23,7 @@ ifdescribe(!process.arch.includes('arm') && process.platform !== 'win32')('deskt
after(closeAllWindows); after(closeAllWindows);
// TODO(nornagon): figure out why this test is failing on Linux and re-enable it. it('should return a non-empty array of sources', async () => {
ifit(process.platform !== 'linux')('should return a non-empty array of sources', async () => {
const sources = await desktopCapturer.getSources({ types: ['window', 'screen'] }); const sources = await desktopCapturer.getSources({ types: ['window', 'screen'] });
expect(sources).to.be.an('array').that.is.not.empty(); expect(sources).to.be.an('array').that.is.not.empty();
}); });
@ -34,8 +33,7 @@ ifdescribe(!process.arch.includes('arm') && process.platform !== 'win32')('deskt
await expect(promise).to.be.eventually.rejectedWith(Error, 'Invalid options'); await expect(promise).to.be.eventually.rejectedWith(Error, 'Invalid options');
}); });
// TODO(nornagon): figure out why this test is failing on Linux and re-enable it. it('does not throw an error when called more than once (regression)', async () => {
ifit(process.platform !== 'linux')('does not throw an error when called more than once (regression)', async () => {
const sources1 = await desktopCapturer.getSources({ types: ['window', 'screen'] }); const sources1 = await desktopCapturer.getSources({ types: ['window', 'screen'] });
expect(sources1).to.be.an('array').that.is.not.empty(); expect(sources1).to.be.an('array').that.is.not.empty();
@ -43,7 +41,7 @@ ifdescribe(!process.arch.includes('arm') && process.platform !== 'win32')('deskt
expect(sources2).to.be.an('array').that.is.not.empty(); expect(sources2).to.be.an('array').that.is.not.empty();
}); });
ifit(process.platform !== 'linux')('responds to subsequent calls of different options', async () => { it('responds to subsequent calls of different options', async () => {
const promise1 = desktopCapturer.getSources({ types: ['window'] }); const promise1 = desktopCapturer.getSources({ types: ['window'] });
await expect(promise1).to.eventually.be.fulfilled(); await expect(promise1).to.eventually.be.fulfilled();
@ -52,7 +50,7 @@ ifdescribe(!process.arch.includes('arm') && process.platform !== 'win32')('deskt
}); });
// Linux doesn't return any window sources. // Linux doesn't return any window sources.
ifit(process.platform !== 'linux')('returns an empty display_id for window sources on Windows and Mac', async () => { ifit(process.platform !== 'linux')('returns an empty display_id for window sources', async () => {
const w = new BrowserWindow({ width: 200, height: 200 }); const w = new BrowserWindow({ width: 200, height: 200 });
await w.loadURL('about:blank'); await w.loadURL('about:blank');
@ -64,7 +62,7 @@ ifdescribe(!process.arch.includes('arm') && process.platform !== 'win32')('deskt
} }
}); });
ifit(process.platform !== 'linux')('returns display_ids matching the Screen API on Windows and Mac', async () => { ifit(process.platform !== 'linux')('returns display_ids matching the Screen API', async () => {
const displays = screen.getAllDisplays(); const displays = screen.getAllDisplays();
const sources = await desktopCapturer.getSources({ types: ['screen'] }); const sources = await desktopCapturer.getSources({ types: ['screen'] });
expect(sources).to.be.an('array').of.length(displays.length); expect(sources).to.be.an('array').of.length(displays.length);