From 5a4d9807ee2f140186592919cea12c9687f0c370 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Moreno?= Date: Tue, 7 Mar 2017 11:21:51 +0100 Subject: [PATCH 1/2] Update `ses.resolveProxy` return type As far as I'm aware, after using the `ses.resolveProxy` API, it seems to return a string in the shape of `PROXY foopy:80;SOCKS5 bar.com:1080`, not an object. Correct me if I'm wrong. --- docs/api/session.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/api/session.md b/docs/api/session.md index 029b18787cc0..591ac14bde7b 100644 --- a/docs/api/session.md +++ b/docs/api/session.md @@ -204,7 +204,7 @@ The `proxyBypassRules` is a comma separated list of rules described below: * `url` URL * `callback` Function - * `proxy` Object + * `proxy` string Resolves the proxy information for `url`. The `callback` will be called with `callback(proxy)` when the request is performed. From f97066511f77ef1f1b8ae1bf8bad638a2629e7b8 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Tue, 7 Mar 2017 21:25:40 +1100 Subject: [PATCH 2/2] Capitalize type --- docs/api/session.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/api/session.md b/docs/api/session.md index 591ac14bde7b..7c7831c8ac37 100644 --- a/docs/api/session.md +++ b/docs/api/session.md @@ -204,7 +204,7 @@ The `proxyBypassRules` is a comma separated list of rules described below: * `url` URL * `callback` Function - * `proxy` string + * `proxy` String Resolves the proxy information for `url`. The `callback` will be called with `callback(proxy)` when the request is performed.