mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fix brightray::GetApplicationName(), ..Version() on Linux (#11980)

Browse source 
* add brightray API to override app version

* in atom browser, use brightray app version API

* on Linux, have GetApplicationVersion() use brightray version API

* on Linux, implement brightray::GetApplicationName()

* fix typo in brightray API

* make browser.GetName() logic follow GetVersion() logic

* improve variable name in OverrideApplicationVersion declaration

* fix typo in brightray impl
This commit is contained in:
Charles Kerr 2018-02-20 10:16:51 -06:00 • committed by GitHub
parent dc62e51ba4
commit 8d086a43cb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 84 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

16
brightray/common/application_info.cc
View file

@ -4,15 +4,23 @@ namespace brightray {
namespace {
std::string g_overriden_application_name;
std::string g_overridden_application_name;
std::string g_overridden_application_version;
}
void OverrideApplicationName(const std::string& name) {
g_overriden_application_name = name;
g_overridden_application_name = name;
}
std::string GetOverridenApplicationName() {
return g_overriden_application_name;
std::string GetOverriddenApplicationName() {
return g_overridden_application_name;
}
void OverrideApplicationVersion(const std::string& version) {
g_overridden_application_version = version;
}
std::string GetOverriddenApplicationVersion() {
return g_overridden_application_version;
}
} // namespace brightray