mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: Annotate fallthrough switch paths with FALLTHROUGH

Browse source 
The compiler was throwing errors about unannotated fallthroughs when
building with GN.
This commit is contained in:
Jeremy Apthorp 2018-06-20 12:54:42 -07:00
parent 3f40e93ba7
commit 8ccb5cc6eb
4 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/browser/ui/cocoa/atom_ns_window.mm
View file

@ -173,12 +173,12 @@ bool ScopedDisableResize::disable_resize_ = false;
buttonFrame.origin.x += NSWidth(
[[self standardWindowButton:NSWindowMiniaturizeButton] frame]);
buttonFrame.origin.x += windowButtonsInterButtonSpacing_;
// fallthrough
FALLTHROUGH;
case NSWindowMiniaturizeButton:
buttonFrame.origin.x +=
NSWidth([[self standardWindowButton:NSWindowCloseButton] frame]);
buttonFrame.origin.x += windowButtonsInterButtonSpacing_;
// fallthrough
FALLTHROUGH;
default:
break;
}

1
atom/browser/web_dialog_helper.cc
View file

@ -220,6 +220,7 @@ void WebDialogHelper::RunFileChooser(
switch (params.mode) {
case content::FileChooserParams::OpenMultiple:
flags |= file_dialog::FILE_DIALOG_MULTI_SELECTIONS;
FALLTHROUGH;
case content::FileChooserParams::Open:
flags |= file_dialog::FILE_DIALOG_OPEN_FILE;
flags |= file_dialog::FILE_DIALOG_TREAT_PACKAGE_APP_AS_DIRECTORY;