mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: deflake clipboard read/write specs (#47786)

Browse source 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This commit is contained in:
trop[bot] 2025-07-16 12:03:41 -07:00 • committed by GitHub
parent 99cda5805d
commit 8c747d82e1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 21 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

34
spec/chromium-spec.ts
View file

@ -3271,7 +3271,12 @@ describe('navigator.clipboard.read', () => {
await w.loadFile(path.join(fixturesPath, 'pages', 'blank.html')); await w.loadFile(path.join(fixturesPath, 'pages', 'blank.html'));
}); });
const readClipboard: any = () => { const readClipboard = async () => {
if (!w.webContents.isFocused()) {
const focus = once(w.webContents, 'focus');
w.webContents.focus();
await focus;
}
return w.webContents.executeJavaScript(` return w.webContents.executeJavaScript(`
navigator.clipboard.read().then(clipboard => clipboard.toString()).catch(err => err.message); navigator.clipboard.read().then(clipboard => clipboard.toString()).catch(err => err.message);
`, true); `, true);
@ -3289,11 +3294,7 @@ describe('navigator.clipboard.read', () => {
it('returns an error when permission denied', async () => { it('returns an error when permission denied', async () => {
session.defaultSession.setPermissionRequestHandler((wc, permission, callback) => { session.defaultSession.setPermissionRequestHandler((wc, permission, callback) => {
if (permission === 'clipboard-read') { callback(permission !== 'clipboard-read');
callback(false);
} else {
callback(true);
}
}); });
const clipboard = await readClipboard(); const clipboard = await readClipboard();
expect(clipboard).to.contain('Read permission denied.'); expect(clipboard).to.contain('Read permission denied.');
@ -3301,11 +3302,7 @@ describe('navigator.clipboard.read', () => {
it('returns clipboard contents when permission is granted', async () => { it('returns clipboard contents when permission is granted', async () => {
session.defaultSession.setPermissionRequestHandler((wc, permission, callback) => { session.defaultSession.setPermissionRequestHandler((wc, permission, callback) => {
if (permission === 'clipboard-read') { callback(permission === 'clipboard-read');
callback(true);
} else {
callback(false);
}
}); });
const clipboard = await readClipboard(); const clipboard = await readClipboard();
expect(clipboard).to.not.contain('Read permission denied.'); expect(clipboard).to.not.contain('Read permission denied.');
@ -3319,7 +3316,12 @@ describe('navigator.clipboard.write', () => {
await w.loadFile(path.join(fixturesPath, 'pages', 'blank.html')); await w.loadFile(path.join(fixturesPath, 'pages', 'blank.html'));
}); });
const writeClipboard: any = () => { const writeClipboard = async () => {
if (!w.webContents.isFocused()) {
const focus = once(w.webContents, 'focus');
w.webContents.focus();
await focus;
}
return w.webContents.executeJavaScript(` return w.webContents.executeJavaScript(`
navigator.clipboard.writeText('Hello World!').catch(err => err.message); navigator.clipboard.writeText('Hello World!').catch(err => err.message);
`, true); `, true);
@ -3361,7 +3363,13 @@ describe('navigator.clipboard.write', () => {
}); });
describe('paste execCommand', () => { describe('paste execCommand', () => {
const readClipboard: any = (w: BrowserWindow) => { const readClipboard = async (w: BrowserWindow) => {
if (!w.webContents.isFocused()) {
const focus = once(w.webContents, 'focus');
w.webContents.focus();
await focus;
}
return w.webContents.executeJavaScript(` return w.webContents.executeJavaScript(`
new Promise((resolve) => { new Promise((resolve) => {
const timeout = setTimeout(() => { const timeout = setTimeout(() => {