From a538b37854e608cce7afa600bc3b8d33d54763e7 Mon Sep 17 00:00:00 2001 From: Toon Borgers Date: Wed, 5 Oct 2016 09:16:34 +0200 Subject: [PATCH 1/5] Create CONTRIBUTING.md --- docs-translations/nl/project/CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs-translations/nl/project/CONTRIBUTING.md diff --git a/docs-translations/nl/project/CONTRIBUTING.md b/docs-translations/nl/project/CONTRIBUTING.md new file mode 100644 index 000000000000..8b137891791f --- /dev/null +++ b/docs-translations/nl/project/CONTRIBUTING.md @@ -0,0 +1 @@ + From 0babe4a5ed551aff878e71d1e07b3ffb7177db3c Mon Sep 17 00:00:00 2001 From: Toon Borgers Date: Wed, 5 Oct 2016 09:27:20 +0200 Subject: [PATCH 2/5] Add english version to start from --- docs-translations/nl/project/CONTRIBUTING.md | 78 ++++++++++++++++++++ 1 file changed, 78 insertions(+) diff --git a/docs-translations/nl/project/CONTRIBUTING.md b/docs-translations/nl/project/CONTRIBUTING.md index 8b137891791f..e61711e356ec 100644 --- a/docs-translations/nl/project/CONTRIBUTING.md +++ b/docs-translations/nl/project/CONTRIBUTING.md @@ -1 +1,79 @@ +# Contributing to Electron +:memo: Available Translations: [Korean](https://github.com/electron/electron/tree/master/docs-translations/ko-KR/project/CONTRIBUTING.md) | [Simplified Chinese](https://github.com/electron/electron/tree/master/docs-translations/zh-CN/project/CONTRIBUTING.md) | [Brazilian Portuguese](https://github.com/electron/electron/tree/master/docs-translations/pt-BR/project/CONTRIBUTING.md) + +:+1::tada: First off, thanks for taking the time to contribute! :tada::+1: + +This project adheres to the Contributor Covenant [code of conduct](CODE_OF_CONDUCT.md). +By participating, you are expected to uphold this code. Please report unacceptable +behavior to atom@github.com. + +The following is a set of guidelines for contributing to Electron. +These are just guidelines, not rules, use your best judgment and feel free to +propose changes to this document in a pull request. + +## Submitting Issues + +* You can create an issue [here](https://github.com/electron/electron/issues/new), +but before doing that please read the notes below and include as many details as +possible with your report. If you can, please include: + * The version of Electron you are using + * The operating system you are using + * If applicable, what you were doing when the issue arose and what you + expected to happen +* Other things that will help resolve your issue: + * Screenshots and animated GIFs + * Error output that appears in your terminal, dev tools or as an alert + * Perform a [cursory search](https://github.com/electron/electron/issues?utf8=✓&q=is%3Aissue+) + to see if a similar issue has already been submitted + +## Submitting Pull Requests + +* Include screenshots and animated GIFs in your pull request whenever possible. +* Follow the JavaScript, C++, and Python [coding style defined in docs](/docs/development/coding-style.md). +* Write documentation in [Markdown](https://daringfireball.net/projects/markdown). + See the [Documentation Styleguide](/docs/styleguide.md). +* Use short, present tense commit messages. See [Commit Message Styleguide](#git-commit-messages). + +## Styleguides + +### General Code + +* End files with a newline. +* Place requires in the following order: + * Built in Node Modules (such as `path`) + * Built in Electron Modules (such as `ipc`, `app`) + * Local Modules (using relative paths) +* Place class properties in the following order: + * Class methods and properties (methods starting with a `@`) + * Instance methods and properties +* Avoid platform-dependent code: + * Use `path.join()` to concatenate filenames. + * Use `os.tmpdir()` rather than `/tmp` when you need to reference the + temporary directory. +* Using a plain `return` when returning explicitly at the end of a function. + * Not `return null`, `return undefined`, `null`, or `undefined` + +### Git Commit Messages + +* Use the present tense ("Add feature" not "Added feature") +* Use the imperative mood ("Move cursor to..." not "Moves cursor to...") +* Limit the first line to 72 characters or less +* Reference issues and pull requests liberally +* When only changing documentation, include `[ci skip]` in the commit description +* Consider starting the commit message with an applicable emoji: + * :art: `:art:` when improving the format/structure of the code + * :racehorse: `:racehorse:` when improving performance + * :non-potable_water: `:non-potable_water:` when plugging memory leaks + * :memo: `:memo:` when writing docs + * :penguin: `:penguin:` when fixing something on Linux + * :apple: `:apple:` when fixing something on macOS + * :checkered_flag: `:checkered_flag:` when fixing something on Windows + * :bug: `:bug:` when fixing a bug + * :fire: `:fire:` when removing code or files + * :green_heart: `:green_heart:` when fixing the CI build + * :white_check_mark: `:white_check_mark:` when adding tests + * :lock: `:lock:` when dealing with security + * :arrow_up: `:arrow_up:` when upgrading dependencies + * :arrow_down: `:arrow_down:` when downgrading dependencies + * :shirt: `:shirt:` when removing linter warnings From d4bbc240312823a6d0637dfb1b4d4f919c3b9bc4 Mon Sep 17 00:00:00 2001 From: Toon Borgers Date: Wed, 5 Oct 2016 12:25:50 +0200 Subject: [PATCH 3/5] Translate CONTRIBUTING.md --- docs-translations/nl/project/CONTRIBUTING.md | 127 +++++++++---------- 1 file changed, 61 insertions(+), 66 deletions(-) diff --git a/docs-translations/nl/project/CONTRIBUTING.md b/docs-translations/nl/project/CONTRIBUTING.md index e61711e356ec..8ed29602d0f0 100644 --- a/docs-translations/nl/project/CONTRIBUTING.md +++ b/docs-translations/nl/project/CONTRIBUTING.md @@ -1,79 +1,74 @@ -# Contributing to Electron +# Bijdragen aan Electron -:memo: Available Translations: [Korean](https://github.com/electron/electron/tree/master/docs-translations/ko-KR/project/CONTRIBUTING.md) | [Simplified Chinese](https://github.com/electron/electron/tree/master/docs-translations/zh-CN/project/CONTRIBUTING.md) | [Brazilian Portuguese](https://github.com/electron/electron/tree/master/docs-translations/pt-BR/project/CONTRIBUTING.md) +:memo: Beschikbare vertalingen: [Koreaans](https://github.com/electron/electron/tree/master/docs-translations/ko-KR/project/CONTRIBUTING.md) | [Versimpeld Chinees](https://github.com/electron/electron/tree/master/docs-translations/zh-CN/project/CONTRIBUTING.md) | [Braziliaans Portugees](https://github.com/electron/electron/tree/master/docs-translations/pt-BR/project/CONTRIBUTING.md) -:+1::tada: First off, thanks for taking the time to contribute! :tada::+1: +:+1::tada: Ten eerste, bedankt om de tijd te nemen om bij te dragen! :tada::+1: -This project adheres to the Contributor Covenant [code of conduct](CODE_OF_CONDUCT.md). -By participating, you are expected to uphold this code. Please report unacceptable -behavior to atom@github.com. +Dit project volgt de [gedragscode](CODE_OF_CONDUCT.md) van bijdragers. +Door deel te nemen, wordt je verwacht je aan deze code te houden. Onaanvaardbaar gedrag moet gerapporteerd worden bij atom@github.com. -The following is a set of guidelines for contributing to Electron. -These are just guidelines, not rules, use your best judgment and feel free to -propose changes to this document in a pull request. +Dit is een set van richtlijnen om bij te dragen aan Electron. +Dit zijn slechts richtijnen, geen regels, gebruik je gezond verstand voe je vrij om wijzigingen aan dit document voor te stellen in een pull request. -## Submitting Issues +## Issues indienen -* You can create an issue [here](https://github.com/electron/electron/issues/new), -but before doing that please read the notes below and include as many details as -possible with your report. If you can, please include: - * The version of Electron you are using - * The operating system you are using - * If applicable, what you were doing when the issue arose and what you - expected to happen -* Other things that will help resolve your issue: - * Screenshots and animated GIFs - * Error output that appears in your terminal, dev tools or as an alert - * Perform a [cursory search](https://github.com/electron/electron/issues?utf8=✓&q=is%3Aissue+) - to see if a similar issue has already been submitted +* Je kan [hier](https://github.com/electron/electron/issues/new) een issue indienen, +maar lees eerst onderstaande suggesties en voeg zo veel mogelijk details toe bij je indiening. Indien mogelijk, voeg dan toe: + * De versie van Electron die je gebruikt + * Het besturingssysteem dat je gebruikt + * Indien mogelijk, wat je aan het doen was toen het probleem zich voor deed en wat je verwachtte dat zou gebeuren +* Andere dingen die kunnen helpen bij het oplossen van je probleem: + * Schermafbeeldingen en geanimeerde GIFs + * Foutmeldingen die voorkomen in je terminal, ontwikkeltools of als melding + * Doe een [vluchtig onderzoek](https://github.com/electron/electron/issues?utf8=✓&q=is%3Aissue+) + om te zien of een gelijkaardig probleem al is gemeld -## Submitting Pull Requests +## Pull Requests Indienen -* Include screenshots and animated GIFs in your pull request whenever possible. -* Follow the JavaScript, C++, and Python [coding style defined in docs](/docs/development/coding-style.md). -* Write documentation in [Markdown](https://daringfireball.net/projects/markdown). - See the [Documentation Styleguide](/docs/styleguide.md). -* Use short, present tense commit messages. See [Commit Message Styleguide](#git-commit-messages). +* Voeg screenshots en geanimeerde GIFs toe in je pull request wanneer mogelijk. +* Volg de JavaScript, C++ en Python [codeer-stijl gedefinieerd in de documentatie](/docs/development/coding-style.md). +* Schrijf documentatie in in [Markdown](https://daringfireball.net/projects/markdown). + Zie de [Documentatie Stijlgids](/docs/styleguide.md). +* Gebruik korte commit-berichten in de tegenwoordige tijd. Zie [Commit Bericht Stijlgids](#git-commit-messages). -## Styleguides +## Stijlgidsen -### General Code +### Code -* End files with a newline. -* Place requires in the following order: - * Built in Node Modules (such as `path`) - * Built in Electron Modules (such as `ipc`, `app`) - * Local Modules (using relative paths) -* Place class properties in the following order: - * Class methods and properties (methods starting with a `@`) - * Instance methods and properties -* Avoid platform-dependent code: - * Use `path.join()` to concatenate filenames. - * Use `os.tmpdir()` rather than `/tmp` when you need to reference the - temporary directory. -* Using a plain `return` when returning explicitly at the end of a function. - * Not `return null`, `return undefined`, `null`, or `undefined` +* Beëindig bestanden met een newline. +* Requires in de volgende volgorde: + * Ingebouwde Node Modules (zoals `path`) + * Ingebouwde Electron Modules (zoals `ipc`, `app`) + * Lokale Modules (met relatieve paden) +* Klasse-properties moeten in volgende volgorde: + * Klasse-methodes en properties (methodes starten met `@`) + * Instance-methodes en properties +* Vermijd platform-afhankelijke code: + * Gebruik `path.join()` om filenames te concateneren. + * Gebruik `os.tmpdir()` in plaats van `/tmp` voor de tijdelijke directory. +* Gebruik een gewone `return` wanneer je expliciet uit een functie returned. + * Geen `return null`, `return undefined`, `null`, of `undefined` -### Git Commit Messages +### Git Commit Berichten -* Use the present tense ("Add feature" not "Added feature") -* Use the imperative mood ("Move cursor to..." not "Moves cursor to...") -* Limit the first line to 72 characters or less -* Reference issues and pull requests liberally -* When only changing documentation, include `[ci skip]` in the commit description -* Consider starting the commit message with an applicable emoji: - * :art: `:art:` when improving the format/structure of the code - * :racehorse: `:racehorse:` when improving performance - * :non-potable_water: `:non-potable_water:` when plugging memory leaks - * :memo: `:memo:` when writing docs - * :penguin: `:penguin:` when fixing something on Linux - * :apple: `:apple:` when fixing something on macOS - * :checkered_flag: `:checkered_flag:` when fixing something on Windows - * :bug: `:bug:` when fixing a bug - * :fire: `:fire:` when removing code or files - * :green_heart: `:green_heart:` when fixing the CI build - * :white_check_mark: `:white_check_mark:` when adding tests - * :lock: `:lock:` when dealing with security - * :arrow_up: `:arrow_up:` when upgrading dependencies - * :arrow_down: `:arrow_down:` when downgrading dependencies - * :shirt: `:shirt:` when removing linter warnings +* Gebruik tegenwoordige tijd ("Add feature" niet "Added feature") +* Gebruik gebiedende wijs ("Move cursor to..." niet "Moves cursor to...") +* De eerste lijn mag maximum 72 karakters lang zijn +* Refereer uitvoerig naar issues en pull requests +* Wanneer je enkel documentatie wijzigt, voeg dan `[ci skip]` toe aan het commit-bericht +* Wanneer toepasbaar, begin je commit-bericht met volgende emoji: + * :art: `:art:` als het formaat/de structuur van de code wordt verbeterd + * :racehorse: `:racehorse:` als de performantie van de code wordt verbeterd + * :non-potable_water: `:non-potable_water:` als memory leaks worden opgelost + * :memo: `:memo:` als documentie is geschreven + * :penguin: `:penguin:` als er iets Linux-gerelateerd is opgelost + * :apple: `:apple:` als er iets macOS-gerelateerd is opgelost + * :checkered_flag: `:checkered_flag:` als er iets Windows-gerelateerd is opgelost + * :bug: `:bug:` als een bug is opgelost + * :fire: `:fire:` als code of bestanden worden verwijderd + * :green_heart: `:green_heart:` als de CI build wordt gefixt + * :white_check_mark: `:white_check_mark:` als er tests worden toegevoegd + * :lock: `:lock:` als er iets met security wordt gedaan + * :arrow_up: `:arrow_up:` als dependencies worden geüpgraded + * :arrow_down: `:arrow_down:` als dependencies worden gedownpgraded + * :shirt: `:shirt:` als linter waarschuwingen worden opgelost From a097d17166a494afaa53cc46581ff8a53f9f1a9f Mon Sep 17 00:00:00 2001 From: Toon Borgers Date: Wed, 5 Oct 2016 12:28:08 +0200 Subject: [PATCH 4/5] Fix relative link, added translation link for dutch --- docs-translations/nl/project/CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs-translations/nl/project/CONTRIBUTING.md b/docs-translations/nl/project/CONTRIBUTING.md index 8ed29602d0f0..e26f08030aba 100644 --- a/docs-translations/nl/project/CONTRIBUTING.md +++ b/docs-translations/nl/project/CONTRIBUTING.md @@ -1,6 +1,6 @@ # Bijdragen aan Electron -:memo: Beschikbare vertalingen: [Koreaans](https://github.com/electron/electron/tree/master/docs-translations/ko-KR/project/CONTRIBUTING.md) | [Versimpeld Chinees](https://github.com/electron/electron/tree/master/docs-translations/zh-CN/project/CONTRIBUTING.md) | [Braziliaans Portugees](https://github.com/electron/electron/tree/master/docs-translations/pt-BR/project/CONTRIBUTING.md) +:memo: Beschikbare vertalingen: [Koreaans](https://github.com/electron/electron/tree/master/docs-translations/ko-KR/project/CONTRIBUTING.md) | [Versimpeld Chinees](https://github.com/electron/electron/tree/master/docs-translations/zh-CN/project/CONTRIBUTING.md) | [Braziliaans Portugees](https://github.com/electron/electron/tree/master/docs-translations/pt-BR/project/CONTRIBUTING.md) | [Nederlands](https://github.com/electron/electron/tree/master/docs-translations/nl/project/CONTRIBUTING.md) :+1::tada: Ten eerste, bedankt om de tijd te nemen om bij te dragen! :tada::+1: @@ -29,7 +29,7 @@ maar lees eerst onderstaande suggesties en voeg zo veel mogelijk details toe bij * Volg de JavaScript, C++ en Python [codeer-stijl gedefinieerd in de documentatie](/docs/development/coding-style.md). * Schrijf documentatie in in [Markdown](https://daringfireball.net/projects/markdown). Zie de [Documentatie Stijlgids](/docs/styleguide.md). -* Gebruik korte commit-berichten in de tegenwoordige tijd. Zie [Commit Bericht Stijlgids](#git-commit-messages). +* Gebruik korte commit-berichten in de tegenwoordige tijd. Zie [Commit Bericht Stijlgids](##git-commit-berichten). ## Stijlgidsen From 25659e482e2a4052172293eef8d4b25c48226054 Mon Sep 17 00:00:00 2001 From: Toon Borgers Date: Wed, 5 Oct 2016 12:28:36 +0200 Subject: [PATCH 5/5] Fix relative url --- docs-translations/nl/project/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs-translations/nl/project/CONTRIBUTING.md b/docs-translations/nl/project/CONTRIBUTING.md index e26f08030aba..6c7cdc481e41 100644 --- a/docs-translations/nl/project/CONTRIBUTING.md +++ b/docs-translations/nl/project/CONTRIBUTING.md @@ -29,7 +29,7 @@ maar lees eerst onderstaande suggesties en voeg zo veel mogelijk details toe bij * Volg de JavaScript, C++ en Python [codeer-stijl gedefinieerd in de documentatie](/docs/development/coding-style.md). * Schrijf documentatie in in [Markdown](https://daringfireball.net/projects/markdown). Zie de [Documentatie Stijlgids](/docs/styleguide.md). -* Gebruik korte commit-berichten in de tegenwoordige tijd. Zie [Commit Bericht Stijlgids](##git-commit-berichten). +* Gebruik korte commit-berichten in de tegenwoordige tijd. Zie [Commit Bericht Stijlgids](#git-commit-berichten). ## Stijlgidsen