From 8bbe28e99876f207c3b159fdaf75a585282ec2a0 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 6 Mar 2018 15:32:00 +0900 Subject: [PATCH] No need to get BrowserContext from NativeWindow --- atom/browser/native_window_mac.mm | 1 - atom/browser/web_dialog_helper.cc | 8 ++------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/atom/browser/native_window_mac.mm b/atom/browser/native_window_mac.mm index 412e85f39d31..60bbebc66250 100644 --- a/atom/browser/native_window_mac.mm +++ b/atom/browser/native_window_mac.mm @@ -990,7 +990,6 @@ NativeWindowMac::NativeWindowMac( NativeWindowMac::~NativeWindowMac() { [NSEvent removeMonitor:wheel_event_monitor_]; - Observe(nullptr); } void NativeWindowMac::Close() { diff --git a/atom/browser/web_dialog_helper.cc b/atom/browser/web_dialog_helper.cc index 1dd479883d87..878b4176a9d0 100644 --- a/atom/browser/web_dialog_helper.cc +++ b/atom/browser/web_dialog_helper.cc @@ -235,12 +235,8 @@ void WebDialogHelper::RunFileChooser( NOTREACHED(); } - AtomBrowserContext* browser_context = static_cast( - window_->web_contents()->GetBrowserContext()); - if (!browser_context) { - browser_context = static_cast( - render_frame_host->GetProcess()->GetBrowserContext()); - } + auto* browser_context = static_cast( + render_frame_host->GetProcess()->GetBrowserContext()); settings.default_path = browser_context->prefs()->GetFilePath( prefs::kSelectFileLastDirectory).Append(params.default_file_name); settings.properties = flags;