refactor: eliminate brightray (#15240)
This commit is contained in:
parent
1d8ab03146
commit
8ba271efba
47 changed files with 178 additions and 234 deletions
|
@ -8,8 +8,7 @@ be found in the `.gn` and `.gni` files.
|
|||
|
||||
The following `gn` files contain the main rules for building Electron:
|
||||
|
||||
* `BUILD.gn` defines how Electron itself is built.
|
||||
* `brightray/BUILD.gn` defines how `brightray` is built and
|
||||
* `BUILD.gn` defines how Electron itself is built and
|
||||
includes the default configurations for linking with Chromium.
|
||||
* `build/args/{debug,release,all}.gn` contain the default build arguments for
|
||||
building Electron.
|
||||
|
|
|
@ -48,8 +48,7 @@ still set breakpoints - Visual Studio will automatically figure out that the
|
|||
source code matches the code running in the attached process and break
|
||||
accordingly.
|
||||
|
||||
Relevant code files can be found in `./atom/` as well as in Brightray, found in
|
||||
`./brightray/browser` and `./brightray/common`.
|
||||
Relevant code files can be found in `./atom/`.
|
||||
|
||||
### Attaching
|
||||
|
||||
|
|
|
@ -41,8 +41,7 @@ this basic introduction, let's assume that you're calling a command from JavaScr
|
|||
that isn't behaving correctly - so you'd like to break on that command's C++
|
||||
counterpart inside the Electron source.
|
||||
|
||||
Relevant code files can be found in `./atom/` as well as in Brightray, found in
|
||||
`./brightray/browser` and `./brightray/common`.
|
||||
Relevant code files can be found in `./atom/`.
|
||||
|
||||
Let's assume that you want to debug `app.setName()`, which is defined in `browser.cc`
|
||||
as `Browser::SetName()`. Set the breakpoint using the `breakpoint` command, specifying
|
||||
|
|
|
@ -55,7 +55,7 @@ $ git checkout -b my-branch -t upstream/master
|
|||
### Step 4: Code
|
||||
|
||||
Most pull requests opened against the `electron/electron` repository include
|
||||
changes to either the C/C++ code in the `atom/` or `brightray/` folders,
|
||||
changes to either the C/C++ code in the `atom/` folder,
|
||||
the JavaScript code in the `lib/` folder, the documentation in `docs/api/`
|
||||
or tests in the `spec/` folder.
|
||||
|
||||
|
|
|
@ -31,7 +31,6 @@ Electron
|
|||
| | message loop into Chromium's message loop.
|
||||
| └── api/ - The implementation of common APIs, and foundations of
|
||||
| Electron's built-in modules.
|
||||
├── brightray/ - Thin shim over libcc that makes it easier to use.
|
||||
├── chromium_src/ - Source code copied from Chromium. See below.
|
||||
├── default_app/ - The default page to show when Electron is started without
|
||||
| providing an app.
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue