From 8b49ba1084a0a8bdaf7615b292677bd7ac25d8bb Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Thu, 19 Sep 2024 02:55:54 -0500 Subject: [PATCH] fix: EyeDropper working in devtools (32-x-y) (#43786) fix: EyeDropper working in devtools (#43685) Co-authored-by: Shelley Vohr --- shell/browser/ui/inspectable_web_contents.cc | 8 ++++++++ shell/browser/ui/inspectable_web_contents.h | 3 +++ 2 files changed, 11 insertions(+) diff --git a/shell/browser/ui/inspectable_web_contents.cc b/shell/browser/ui/inspectable_web_contents.cc index 379499856e5..f3181e8065f 100644 --- a/shell/browser/ui/inspectable_web_contents.cc +++ b/shell/browser/ui/inspectable_web_contents.cc @@ -797,6 +797,7 @@ void InspectableWebContents::SetEyeDropperActive(bool active) { if (delegate_) delegate_->DevToolsSetEyeDropperActive(active); } + void InspectableWebContents::ShowCertificateViewer( const std::string& cert_chain) {} @@ -1000,6 +1001,13 @@ void InspectableWebContents::CloseContents(content::WebContents* source) { CloseDevTools(); } +std::unique_ptr InspectableWebContents::OpenEyeDropper( + content::RenderFrameHost* frame, + content::EyeDropperListener* listener) { + auto* delegate = web_contents_->GetDelegate(); + return delegate ? delegate->OpenEyeDropper(frame, listener) : nullptr; +} + void InspectableWebContents::RunFileChooser( content::RenderFrameHost* render_frame_host, scoped_refptr listener, diff --git a/shell/browser/ui/inspectable_web_contents.h b/shell/browser/ui/inspectable_web_contents.h index 361c29ef46c..7898d7f2bd3 100644 --- a/shell/browser/ui/inspectable_web_contents.h +++ b/shell/browser/ui/inspectable_web_contents.h @@ -208,6 +208,9 @@ class InspectableWebContents bool HandleKeyboardEvent(content::WebContents*, const input::NativeWebKeyboardEvent&) override; void CloseContents(content::WebContents* source) override; + std::unique_ptr OpenEyeDropper( + content::RenderFrameHost* frame, + content::EyeDropperListener* listener) override; void RunFileChooser(content::RenderFrameHost* render_frame_host, scoped_refptr listener, const blink::mojom::FileChooserParams& params) override;