mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: add WebFrameMain detached property (#43473)

Browse source 
* feat: add WebFrameMain detached property

fix: throw instead of returning null senderFrame

test: detached frames

fix: ensure IPCs of pending deletion RFHs are dispatched

fix: lookup WFM by FTN ID to dispatch IPCs

feat: add frame.isDestroyed()

return null

fix: return undefined

docs: add null to all frame properties

refactor: option c, return null and emit warning

refactor: add routingId & processId to navigation events

test: null frame property

docs: clarify warning message

better wording

clarify null frame

fix: browserwindow spec

* maybe fix 🤷

* fix: use updated util #43722

* docs: add notice for frame change of behavior

* docs: clarify why frame properties may be null

* lint

* wip

* fix: content::FrameTreeNodeId lookup and converter

* refactor: avoid holey array deoptimization

---------

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
This commit is contained in:
Sam Maddock 2024-10-11 18:33:53 -04:00 • committed by GitHub
parent 527efc01a4
commit 8b3d70a2a3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
20 changed files with 410 additions and 126 deletions
Download patch file Download diff file Expand all files Collapse all files

7
typings/internal-electron.d.ts vendored
View file

@ -177,10 +177,12 @@ declare namespace Electron {
interface IpcMainEvent {
_replyChannel: ReplyChannel;
frameTreeNodeId?: number;
}
interface IpcMainInvokeEvent {
_replyChannel: ReplyChannel;
frameTreeNodeId?: number;
}
// Deprecated / undocumented BrowserWindow methods
@ -225,6 +227,11 @@ declare namespace Electron {
once(event: 'destroyed', listener: (event: Electron.Event) => void): this;
}
interface WebContentsWillFrameNavigateEventParams {
processId: number;
routingId: number;
}
}
declare namespace ElectronInternal {