mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Unlisten the zoom-level-changed event when webview is detached

Browse source
This commit is contained in:
Cheng Zhao 2016-01-13 14:58:16 +08:00
parent 44b8343585
commit 8ae836d82d
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
atom/renderer/lib/web-view/web-view.js
View file

@ -43,9 +43,10 @@ WebViewImpl = (function() {
shadowRoot.appendChild(this.browserPluginNode); shadowRoot.appendChild(this.browserPluginNode);
// Subscribe to host's zoom level changes. // Subscribe to host's zoom level changes.
webFrame.on('zoom-level-changed', (zoomLevel) => { this.onZoomLevelChanged = (zoomLevel) => {
this.webviewNode.setZoomLevel(zoomLevel); this.webviewNode.setZoomLevel(zoomLevel);
}); }
webFrame.on('zoom-level-changed', this.onZoomLevelChanged);
} }
WebViewImpl.prototype.createBrowserPluginNode = function() { WebViewImpl.prototype.createBrowserPluginNode = function() {
@ -64,6 +65,8 @@ WebViewImpl = (function() {
/* Resets some state upon reattaching <webview> element to the DOM. */ /* Resets some state upon reattaching <webview> element to the DOM. */
WebViewImpl.prototype.reset = function() { WebViewImpl.prototype.reset = function() {
// Unlisten the zoom-level-changed event.
webFrame.removeListener('zoom-level-changed', this.onZoomLevelChanged);
/* /*
If guestInstanceId is defined then the <webview> has navigated and has If guestInstanceId is defined then the <webview> has navigated and has