From 8a47acebe711a08dd873e7c1fd563270f41e3a4b Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Mon, 1 Apr 2024 12:05:56 -0400 Subject: [PATCH] docs: add missing headers option to ClientRequest options (#41732) Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Jeremy Rose --- docs/api/client-request.md | 2 ++ spec/api-net-spec.ts | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/api/client-request.md b/docs/api/client-request.md index 440a775267ca..7e2637d207b8 100644 --- a/docs/api/client-request.md +++ b/docs/api/client-request.md @@ -17,6 +17,8 @@ following properties: method. * `url` string (optional) - The request URL. Must be provided in the absolute form with the protocol scheme specified as http or https. + * `headers` Record (optional) - Headers to be sent + with the request. * `session` Session (optional) - The [`Session`](session.md) instance with which the request is associated. * `partition` string (optional) - The name of the [`partition`](session.md) diff --git a/spec/api-net-spec.ts b/spec/api-net-spec.ts index 1a92186742e1..c743632abcfb 100644 --- a/spec/api-net-spec.ts +++ b/spec/api-net-spec.ts @@ -935,12 +935,11 @@ describe('net module', () => { response.end(); }); const serverUrl = url.parse(serverUrlUnparsed); - const options = { + const urlRequest = net.request({ port: serverUrl.port ? parseInt(serverUrl.port, 10) : undefined, hostname: '127.0.0.1', headers: { [customHeaderName]: customHeaderValue } - }; - const urlRequest = net.request(options); + }); const response = await getResponse(urlRequest); expect(response.statusCode).to.be.equal(200); await collectStreamBody(response);