From 8a200e04271ff62d2647055de9299e213514e3cc Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Tue, 25 Feb 2025 22:51:45 -0600 Subject: [PATCH] refactor: remove unused gin_helper::WrappableBase::GetWrapper(v8::Isolate*) (#45808) refactor: remove unused EventEmitter::GetWrapper(v8::Isolate*) Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/common/gin_helper/wrappable.cc | 8 -------- shell/common/gin_helper/wrappable_base.h | 1 - 2 files changed, 9 deletions(-) diff --git a/shell/common/gin_helper/wrappable.cc b/shell/common/gin_helper/wrappable.cc index 81fa5b8373ea..1d0f45e004e4 100644 --- a/shell/common/gin_helper/wrappable.cc +++ b/shell/common/gin_helper/wrappable.cc @@ -29,14 +29,6 @@ v8::Local WrappableBase::GetWrapper() const { return {}; } -v8::MaybeLocal WrappableBase::GetWrapper( - v8::Isolate* isolate) const { - if (!wrapper_.IsEmpty()) - return {v8::Local::New(isolate, wrapper_)}; - else - return {}; -} - void WrappableBase::InitWithArgs(gin::Arguments* args) { v8::Local holder; args->GetHolder(&holder); diff --git a/shell/common/gin_helper/wrappable_base.h b/shell/common/gin_helper/wrappable_base.h index 397fa5171e11..9fa255bfe41f 100644 --- a/shell/common/gin_helper/wrappable_base.h +++ b/shell/common/gin_helper/wrappable_base.h @@ -39,7 +39,6 @@ class WrappableBase { // Retrieve the v8 wrapper object corresponding to this object. v8::Local GetWrapper() const; - v8::MaybeLocal GetWrapper(v8::Isolate* isolate) const; // Returns the Isolate this object is created in. v8::Isolate* isolate() const { return isolate_; }