Use rest parameters
This commit is contained in:
parent
e05804848f
commit
8889c29866
14 changed files with 88 additions and 143 deletions
|
@ -1,27 +1,21 @@
|
|||
'use strict';
|
||||
|
||||
const binding = process.atomBinding('ipc');
|
||||
const v8Util = process.atomBinding('v8_util');
|
||||
|
||||
var slice = [].slice;
|
||||
|
||||
// Created by init.js.
|
||||
const ipcRenderer = v8Util.getHiddenValue(global, 'ipc');
|
||||
|
||||
ipcRenderer.send = function() {
|
||||
var args;
|
||||
args = 1 <= arguments.length ? slice.call(arguments, 0) : [];
|
||||
return binding.send('ipc-message', slice.call(args));
|
||||
ipcRenderer.send = function(...args) {
|
||||
return binding.send('ipc-message', args);
|
||||
};
|
||||
|
||||
ipcRenderer.sendSync = function() {
|
||||
var args;
|
||||
args = 1 <= arguments.length ? slice.call(arguments, 0) : [];
|
||||
return JSON.parse(binding.sendSync('ipc-message-sync', slice.call(args)));
|
||||
ipcRenderer.sendSync = function(...args) {
|
||||
return JSON.parse(binding.sendSync('ipc-message-sync', args));
|
||||
};
|
||||
|
||||
ipcRenderer.sendToHost = function() {
|
||||
var args;
|
||||
args = 1 <= arguments.length ? slice.call(arguments, 0) : [];
|
||||
return binding.send('ipc-message-host', slice.call(args));
|
||||
ipcRenderer.sendToHost = function(...args) {
|
||||
return binding.send('ipc-message-host', args);
|
||||
};
|
||||
|
||||
module.exports = ipcRenderer;
|
||||
|
|
|
@ -2,17 +2,13 @@ const ipcRenderer = require('electron').ipcRenderer;
|
|||
const deprecate = require('electron').deprecate;
|
||||
const EventEmitter = require('events').EventEmitter;
|
||||
|
||||
var slice = [].slice;
|
||||
|
||||
// This module is deprecated, we mirror everything from ipcRenderer.
|
||||
deprecate.warn('ipc module', 'require("electron").ipcRenderer');
|
||||
|
||||
// Routes events of ipcRenderer.
|
||||
var ipc = new EventEmitter;
|
||||
|
||||
ipcRenderer.emit = function() {
|
||||
var channel = arguments[0];
|
||||
var args = 3 <= arguments.length ? slice.call(arguments, 2) : [];
|
||||
ipcRenderer.emit = function(channel, event, ...args) {
|
||||
ipc.emit.apply(ipc, [channel].concat(slice.call(args)));
|
||||
return EventEmitter.prototype.emit.apply(ipcRenderer, arguments);
|
||||
};
|
||||
|
|
|
@ -3,8 +3,6 @@
|
|||
const ipcRenderer = require('electron').ipcRenderer;
|
||||
const remote = require('electron').remote;
|
||||
|
||||
var slice = [].slice;
|
||||
|
||||
// Cache browser window visibility
|
||||
var _isVisible = true;
|
||||
var _isMinimized = false;
|
||||
|
@ -73,10 +71,8 @@ var BrowserWindowProxy = (function() {
|
|||
return ipcRenderer.send('ATOM_SHELL_GUEST_WINDOW_MANAGER_WINDOW_POSTMESSAGE', this.guestId, message, targetOrigin, location.origin);
|
||||
};
|
||||
|
||||
BrowserWindowProxy.prototype["eval"] = function() {
|
||||
var args;
|
||||
args = 1 <= arguments.length ? slice.call(arguments, 0) : [];
|
||||
return ipcRenderer.send.apply(ipcRenderer, ['ATOM_SHELL_GUEST_WINDOW_MANAGER_WEB_CONTENTS_METHOD', this.guestId, 'executeJavaScript'].concat(slice.call(args)));
|
||||
BrowserWindowProxy.prototype["eval"] = function(...args) {
|
||||
return ipcRenderer.send.apply(ipcRenderer, ['ATOM_SHELL_GUEST_WINDOW_MANAGER_WEB_CONTENTS_METHOD', this.guestId, 'executeJavaScript'].concat(args));
|
||||
};
|
||||
|
||||
return BrowserWindowProxy;
|
||||
|
@ -223,16 +219,12 @@ ipcRenderer.on('ATOM_SHELL_GUEST_WINDOW_POSTMESSAGE', function(event, sourceId,
|
|||
});
|
||||
|
||||
// Forward history operations to browser.
|
||||
var sendHistoryOperation = function() {
|
||||
var args;
|
||||
args = 1 <= arguments.length ? slice.call(arguments, 0) : [];
|
||||
return ipcRenderer.send.apply(ipcRenderer, ['ATOM_SHELL_NAVIGATION_CONTROLLER'].concat(slice.call(args)));
|
||||
var sendHistoryOperation = function(...args) {
|
||||
return ipcRenderer.send.apply(ipcRenderer, ['ATOM_SHELL_NAVIGATION_CONTROLLER'].concat(args));
|
||||
};
|
||||
|
||||
var getHistoryOperation = function() {
|
||||
var args;
|
||||
args = 1 <= arguments.length ? slice.call(arguments, 0) : [];
|
||||
return ipcRenderer.sendSync.apply(ipcRenderer, ['ATOM_SHELL_SYNC_NAVIGATION_CONTROLLER'].concat(slice.call(args)));
|
||||
var getHistoryOperation = function(...args) {
|
||||
return ipcRenderer.sendSync.apply(ipcRenderer, ['ATOM_SHELL_SYNC_NAVIGATION_CONTROLLER'].concat(args));
|
||||
};
|
||||
|
||||
window.history.back = function() {
|
||||
|
|
|
@ -1,8 +1,9 @@
|
|||
'use strict';
|
||||
|
||||
const ipcRenderer = require('electron').ipcRenderer;
|
||||
const webFrame = require('electron').webFrame;
|
||||
|
||||
var slice = [].slice;
|
||||
var requestId = 0;
|
||||
var requestId= 0;
|
||||
|
||||
var WEB_VIEW_EVENTS = {
|
||||
'load-commit': ['url', 'isMainFrame'],
|
||||
|
@ -41,11 +42,10 @@ var DEPRECATED_EVENTS = {
|
|||
'page-title-updated': 'page-title-set'
|
||||
};
|
||||
|
||||
var dispatchEvent = function() {
|
||||
var args, domEvent, eventKey, eventName, f, i, j, len, ref1, webView;
|
||||
webView = arguments[0], eventName = arguments[1], eventKey = arguments[2], args = 4 <= arguments.length ? slice.call(arguments, 3) : [];
|
||||
var dispatchEvent = function(webView, eventName, eventKey, ...args) {
|
||||
var domEvent, f, i, j, len, ref1;
|
||||
if (DEPRECATED_EVENTS[eventName] != null) {
|
||||
dispatchEvent.apply(null, [webView, DEPRECATED_EVENTS[eventName], eventKey].concat(slice.call(args)));
|
||||
dispatchEvent.apply(null, [webView, DEPRECATED_EVENTS[eventName], eventKey].concat(args));
|
||||
}
|
||||
domEvent = new Event(eventName);
|
||||
ref1 = WEB_VIEW_EVENTS[eventKey];
|
||||
|
@ -61,22 +61,19 @@ var dispatchEvent = function() {
|
|||
|
||||
module.exports = {
|
||||
registerEvents: function(webView, viewInstanceId) {
|
||||
ipcRenderer.on("ATOM_SHELL_GUEST_VIEW_INTERNAL_DISPATCH_EVENT-" + viewInstanceId, function() {
|
||||
var eventName = arguments[1];
|
||||
var args = 3 <= arguments.length ? slice.call(arguments, 2) : [];
|
||||
return dispatchEvent.apply(null, [webView, eventName, eventName].concat(slice.call(args)));
|
||||
ipcRenderer.on("ATOM_SHELL_GUEST_VIEW_INTERNAL_DISPATCH_EVENT-" + viewInstanceId, function(event, eventName, ...args) {
|
||||
return dispatchEvent.apply(null, [webView, eventName, eventName].concat(args));
|
||||
});
|
||||
ipcRenderer.on("ATOM_SHELL_GUEST_VIEW_INTERNAL_IPC_MESSAGE-" + viewInstanceId, function() {
|
||||
var channel = arguments[1];
|
||||
var args = 3 <= arguments.length ? slice.call(arguments, 2) : [];
|
||||
|
||||
ipcRenderer.on("ATOM_SHELL_GUEST_VIEW_INTERNAL_IPC_MESSAGE-" + viewInstanceId, function(event, channel, ...args) {
|
||||
var domEvent = new Event('ipc-message');
|
||||
domEvent.channel = channel;
|
||||
domEvent.args = slice.call(args);
|
||||
domEvent.args = args;
|
||||
return webView.dispatchEvent(domEvent);
|
||||
});
|
||||
return ipcRenderer.on("ATOM_SHELL_GUEST_VIEW_INTERNAL_SIZE_CHANGED-" + viewInstanceId, function() {
|
||||
var args, domEvent, f, i, j, len, ref1;
|
||||
args = 2 <= arguments.length ? slice.call(arguments, 1) : [];
|
||||
|
||||
return ipcRenderer.on("ATOM_SHELL_GUEST_VIEW_INTERNAL_SIZE_CHANGED-" + viewInstanceId, function(event, ...args) {
|
||||
var domEvent, f, i, j, len, ref1;
|
||||
domEvent = new Event('size-changed');
|
||||
ref1 = ['oldWidth', 'oldHeight', 'newWidth', 'newHeight'];
|
||||
for (i = j = 0, len = ref1.length; j < len; i = ++j) {
|
||||
|
|
|
@ -10,7 +10,6 @@ const guestViewInternal = require('./guest-view-internal');
|
|||
const webViewConstants = require('./web-view-constants');
|
||||
|
||||
var hasProp = {}.hasOwnProperty;
|
||||
var slice = [].slice;
|
||||
|
||||
// ID generator.
|
||||
var nextId = 0;
|
||||
|
@ -392,9 +391,8 @@ var registerWebViewElement = function() {
|
|||
|
||||
// Forward proto.foo* method calls to WebViewImpl.foo*.
|
||||
createBlockHandler = function(m) {
|
||||
return function() {
|
||||
var args = 1 <= arguments.length ? slice.call(arguments, 0) : [];
|
||||
var internal = v8Util.getHiddenValue(this, 'internal');
|
||||
return function(...args) {
|
||||
const internal = v8Util.getHiddenValue(this, 'internal');
|
||||
if (internal.webContents) {
|
||||
return internal.webContents[m].apply(internal.webContents, args);
|
||||
} else {
|
||||
|
@ -407,11 +405,9 @@ var registerWebViewElement = function() {
|
|||
proto[m] = createBlockHandler(m);
|
||||
}
|
||||
createNonBlockHandler = function(m) {
|
||||
return function() {
|
||||
var args, internal;
|
||||
args = 1 <= arguments.length ? slice.call(arguments, 0) : [];
|
||||
internal = v8Util.getHiddenValue(this, 'internal');
|
||||
return ipcRenderer.send.apply(ipcRenderer, ['ATOM_BROWSER_ASYNC_CALL_TO_GUEST_VIEW', null, internal.guestInstanceId, m].concat(slice.call(args)));
|
||||
return function(...args) {
|
||||
const internal = v8Util.getHiddenValue(this, 'internal');
|
||||
return ipcRenderer.send.apply(ipcRenderer, ['ATOM_BROWSER_ASYNC_CALL_TO_GUEST_VIEW', null, internal.guestInstanceId, m].concat(args));
|
||||
};
|
||||
};
|
||||
for (j = 0, len1 = nonblockMethods.length; j < len1; j++) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue