Merge pull request #8724 from electron/defer_load_url

webContents: defer url load when there is a pending navigation entry

spec/api-browser-window-spec.js

@@ -229,6 +229,11 @@ describe('BrowserWindow module', function () {
       w.loadURL(`data:image/png;base64,${data}`)
     })
 
+    it('should not crash when there is a pending navigation entry', function (done) {
+      ipcRenderer.once('navigated-with-pending-entry', () => done())
+      ipcRenderer.send('navigate-with-pending-entry', w.id)
+    })
+
     describe('POST navigations', function () {
       afterEach(() => {
         w.webContents.session.webRequest.onBeforeSendHeaders(null)

spec/static/main.js

@@ -304,6 +304,24 @@ ipcMain.on('handle-unhandled-rejection', (event, message) => {
   })
 })
 
+ipcMain.on('navigate-with-pending-entry', (event, id) => {
+  const w = BrowserWindow.fromId(id)
+
+  w.webContents.on('did-start-loading', () => {
+    w.loadURL('about:blank')
+  })
+
+  w.webContents.on('did-navigate', (e, url) => {
+    if (url === 'about:blank') {
+      event.sender.send('navigated-with-pending-entry')
+    }
+  })
+
+  w.webContents.session.clearHostResolverCache(() => {
+    w.loadURL('http://host')
+  })
+})
+
 // Suspend listeners until the next event and then restore them
 const suspendListeners = (emitter, eventName, callback) => {
   const listeners = emitter.listeners(eventName)