mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Merge pull request #5859 from electron/felix-extension-warning

Browse source 
Log a warning if an extension has already been loaded
This commit is contained in:
Cheng Zhao 2016-06-06 01:22:47 +00:00 • committed by GitHub
commit 8847af0e54
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
docs/api/browser-window.md
View file

@ -380,7 +380,11 @@ Find a window according to its ID.
Adds DevTools extension located at `path`, and returns extension's name. Adds DevTools extension located at `path`, and returns extension's name.
The extension will be remembered so you only need to call this API once, this The extension will be remembered so you only need to call this API once, this
API is not for programming use. API is not for programming use. If you try to add an extension that has already
been loaded, this method will not return and instead log a warning to the
console.
Method will also not return if the extension's manifest is missing or incomplete.
### `BrowserWindow.removeDevToolsExtension(name)` ### `BrowserWindow.removeDevToolsExtension(name)`

2
lib/browser/chrome-extension.js
View file

@ -38,6 +38,8 @@ const getManifestFromPath = function (srcDirectory) {
}) })
}) })
return manifest return manifest
} else if (manifest && manifest.name) {
console.warn(`Attempted to load extension "${manifest.name}", but extension was already loaded!`)
} }
} }