mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 2

feat: expose frame & move properties to console-message event object (#43617)

Browse source 
* feat: expose frame on console-message event

refactor: use property names similar to ServiceWorker's console-message event

refactor: don't use deprecated params in tests

doc: console-message breaking change

chore: add deprecation warning

docs: restore deprecated argument descriptions

* move console-message deprecations to v34

---------

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
This commit is contained in:
Sam Maddock 2024-10-18 16:07:06 -04:00 • committed by GitHub
parent 35aeab6ecd
commit 87bd665e41
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 140 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

6
spec/chromium-spec.ts
View file

@ -379,7 +379,7 @@ describe('web security', () => {
console.log(e.message)
}
</script>`);
const [,, message] = await once(w.webContents, 'console-message');
const [{ message }] = await once(w.webContents, 'console-message');
expect(message).to.match(/Refused to evaluate a string/);
});
@ -399,7 +399,7 @@ describe('web security', () => {
console.log(e.message)
}
</script>`);
const [,, message] = await once(w.webContents, 'console-message');
const [{ message }] = await once(w.webContents, 'console-message');
expect(message).to.equal('true');
});
@ -1428,7 +1428,7 @@ describe('chromium features', () => {
w.loadURL('about:blank');
w.webContents.executeJavaScript('window.child = window.open(); child.opener = null');
const [, { webContents }] = await once(app, 'browser-window-created');
const [,, message] = await once(webContents, 'console-message');
const [{ message }] = await once(webContents, 'console-message');
expect(message).to.equal('{"require":"function","module":"object","exports":"object","process":"object","Buffer":"function"}');
});