feat: expose frame & move properties to console-message event object (#43617)
* feat: expose frame on console-message event refactor: use property names similar to ServiceWorker's console-message event refactor: don't use deprecated params in tests doc: console-message breaking change chore: add deprecation warning docs: restore deprecated argument descriptions * move console-message deprecations to v34 --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
This commit is contained in:
parent
35aeab6ecd
commit
87bd665e41
13 changed files with 140 additions and 65 deletions
|
@ -1965,9 +1965,9 @@ describe('webContents module', () => {
|
|||
afterEach(closeAllWindows);
|
||||
it('is triggered with correct log message', (done) => {
|
||||
const w = new BrowserWindow({ show: true });
|
||||
w.webContents.on('console-message', (e, level, message) => {
|
||||
w.webContents.on('console-message', (e) => {
|
||||
// Don't just assert as Chromium might emit other logs that we should ignore.
|
||||
if (message === 'a') {
|
||||
if (e.message === 'a') {
|
||||
done();
|
||||
}
|
||||
});
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue