mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: remove 'remote' usage from process tests (#20418)

Browse source
This commit is contained in:
Jeremy Apthorp 2019-10-04 13:58:44 -07:00 • committed by GitHub
parent ccff140046
commit 87bd0501c4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
spec/api-process-spec.js
View file

@ -1,4 +1,4 @@
const { remote } = require('electron') const { ipcRenderer } = require('electron')
const fs = require('fs') const fs = require('fs')
const path = require('path') const path = require('path')
@ -89,8 +89,8 @@ describe('process module', () => {
}) })
describe('process.takeHeapSnapshot()', () => { describe('process.takeHeapSnapshot()', () => {
it('returns true on success', () => { it('returns true on success', async () => {
const filePath = path.join(remote.app.getPath('temp'), 'test.heapsnapshot') const filePath = path.join(await ipcRenderer.invoke('get-temp-dir'), 'test.heapsnapshot')
const cleanup = () => { const cleanup = () => {
try { try {

2
spec/static/main.js
View file

@ -42,6 +42,8 @@ ipcMain.on('message', function (event, ...args) {
event.sender.send('message', ...args) event.sender.send('message', ...args)
}) })
ipcMain.handle('get-temp-dir', () => app.getPath('temp'))
// Set productName so getUploadedReports() uses the right directory in specs // Set productName so getUploadedReports() uses the right directory in specs
if (process.platform !== 'darwin') { if (process.platform !== 'darwin') {
crashReporter.productName = 'Zombies' crashReporter.productName = 'Zombies'