mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

chore: replace ShowWithWindowState with Show inside native_window_views

Browse source 
The functionality was merged in as a parameter to the core Show method, default
for restore_bounds is an empty gfx::Rect()

refs: https://chromium-review.googlesource.com/c/chromium/src/+/1174910
This commit is contained in:
Samuel Attard 2018-10-27 14:49:13 +11:00 • committed by deepak1556
parent f8f091c250
commit 85fdacbc49
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
atom/browser/native_window_views.cc
View file

@ -347,7 +347,7 @@ void NativeWindowViews::Show() {
!widget()->native_widget_private()->IsVisible())
static_cast<NativeWindowViews*>(parent())->IncrementChildModals();
widget()->native_widget_private()->ShowWithWindowState(GetRestoredState());
widget()->native_widget_private()->Show(GetRestoredState(), gfx::Rect());
NotifyWindowShow();
@ -454,8 +454,8 @@ void NativeWindowViews::Maximize() {
if (IsVisible())
widget()->Maximize();
else
widget()->native_widget_private()->ShowWithWindowState(
ui::SHOW_STATE_MAXIMIZED);
widget()->native_widget_private()->Show(ui::SHOW_STATE_MAXIMIZED,
gfx::Rect());
}
void NativeWindowViews::Unmaximize() {
@ -477,8 +477,8 @@ void NativeWindowViews::Minimize() {
if (IsVisible())
widget()->Minimize();
else
widget()->native_widget_private()->ShowWithWindowState(
ui::SHOW_STATE_MINIMIZED);
widget()->native_widget_private()->Show(ui::SHOW_STATE_MINIMIZED,
gfx::Rect());
}
void NativeWindowViews::Restore() {
@ -533,8 +533,8 @@ void NativeWindowViews::SetFullScreen(bool fullscreen) {
if (IsVisible())
widget()->SetFullscreen(fullscreen);
else if (fullscreen)
widget()->native_widget_private()->ShowWithWindowState(
ui::SHOW_STATE_FULLSCREEN);
widget()->native_widget_private()->Show(ui::SHOW_STATE_FULLSCREEN,
gfx::Rect());
// Auto-hide menubar when in fullscreen.
if (fullscreen)