mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: guard against duplicate TouchBarItem IDs (#22272)

Browse source 
* feat: Add OtherItemsProxy touchbar item

* review!

* fix: guard against duplicate TouchBarItem IDs

* add spec
This commit is contained in:
Erick Zhao 2020-02-26 14:12:56 -08:00 • committed by GitHub
parent 12c1d4411d
commit 85ef762269
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
spec-main/api-touch-bar-spec.ts
View file

@ -39,6 +39,14 @@ describe('TouchBar module', () => {
}).to.throw('Must only have one OtherItemsProxy per TouchBar')
})
it('throws an error if the same TouchBarItem is added multiple times', () => {
expect(() => {
const item = new TouchBarLabel({ label: 'Label' })
const touchBar = new TouchBar({ items: [item, item] })
touchBar.toString()
}).to.throw('Cannot add a single instance of TouchBarItem multiple times in a TouchBar')
})
describe('BrowserWindow behavior', () => {
let window: BrowserWindow