chore: Add patch to partially revert chromium crashpad change (#17978)

This adds a patch to support functionality that we were using but chromium changed it. Electron uses breakpad on windows, chromium uses crashpad (which is newer). So this patch is needed until we update electron to use crashpad for windows.
This commit is contained in:
Nitish Sakhawalkar 2019-05-10 10:35:17 -07:00 committed by GitHub
parent 8de9ba6df6
commit 85c24c0b47
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 145 additions and 4 deletions

View file

@ -133,14 +133,13 @@ bool RegisterNonABICompliantCodeRange(void* start, size_t size_in_bytes) {
reinterpret_cast<DWORD64>(start));
}
/*
void UnregisterNonABICompliantCodeRange(void* start) {
ExceptionHandlerRecord* record =
reinterpret_cast<ExceptionHandlerRecord*>(start);
RtlDeleteFunctionTable(&record->runtime_function);
}
*/
#endif // _WIN64
} // namespace
@ -196,8 +195,8 @@ void CrashReporterWin::InitBreakpad(const std::string& product_name,
if (code_range && size &&
RegisterNonABICompliantCodeRange(code_range, size)) {
// FIXME(nornagon): This broke with https://crrev.com/c/1474703
// gin::Debug::SetCodeRangeDeletedCallback(
// UnregisterNonABICompliantCodeRange);
gin::Debug::SetCodeRangeDeletedCallback(
UnregisterNonABICompliantCodeRange);
}
}
#endif