fix: fallback to FullSizeContentView for frameless window on mac (#13600)

When using `views::Widget` to create window, Chromium will automatically
use a `BridgedContentView` as content view, which however does not
support draggable regions inside it.

By fallback to `FullSizeContentView` we can work around this problem,
with the price of losing the ability to use `views::View` APIs. Since
we don't expect users to use the new `View` APIs in `BrowserWindow`
anyway, it should not be a problem.

This change does not affect users of `TopLevelWindow`, and for users of
`BrowserWindow` there is nothing to lose.

In the long term we should look into how to make draggable regions work
with `BridgedContentView`. The related Chromium code is still being
changed rapidly, we can wait until Chromium migrated its
`NativeAppWindowCocoa` class to use `views::Widget`.
This commit is contained in:
trop[bot] 2018-07-10 13:09:46 +09:00 committed by Cheng Zhao
parent f6ae438005
commit 85526c7f21
5 changed files with 123 additions and 55 deletions

View file

@ -85,6 +85,11 @@ BrowserWindow::BrowserWindow(v8::Isolate* isolate,
InitWith(isolate, wrapper);
#if defined(OS_MACOSX)
if (!window()->has_frame())
OverrideNSWindowContentView();
#endif
// Init window after everything has been setup.
window()->InitFromOptions(options);
}