mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

build: upload the file stream not a JSON blob for the read stream (#24889)

Browse source
This commit is contained in:
Samuel Attard 2020-08-07 12:00:12 -07:00 • committed by GitHub
parent cbdfeb1979
commit 854b74809a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
script/release/release.js
View file

@ -252,7 +252,7 @@ async function uploadShasumFile (filePath, fileName, releaseId) {
'content-type': 'text/plain', 'content-type': 'text/plain',
'content-length': fs.statSync(filePath).size 'content-length': fs.statSync(filePath).size
}, },
file: fs.createReadStream(filePath), data: fs.createReadStream(filePath),
name: fileName name: fileName
}).catch(err => { }).catch(err => {
console.log(`${fail} Error uploading ${filePath} to GitHub:`, err); console.log(`${fail} Error uploading ${filePath} to GitHub:`, err);

2
script/release/uploaders/upload-to-github.js
View file

@ -41,7 +41,7 @@ function uploadToGitHub () {
octokit.repos.uploadReleaseAsset({ octokit.repos.uploadReleaseAsset({
url: uploadUrl, url: uploadUrl,
headers: getHeaders(filePath, fileName), headers: getHeaders(filePath, fileName),
file: fs.createReadStream(filePath), data: fs.createReadStream(filePath),
name: fileName name: fileName
}).then(() => { }).then(() => {
console.log(`Successfully uploaded ${fileName} to GitHub.`); console.log(`Successfully uploaded ${fileName} to GitHub.`);