chore: cleanup tests creating crashpad handler in the test runner process (#40668)
* chore: cleanup tests creating crashpad handler in the test runner process * ci: logging * ci: enable logging * ci: more logging * ci: run all tests * ci: more logging * ci: increase timeout * Revert "ci: increase timeout" This reverts commit 870f74455da12fdcfb4b9b299944e6d549dc76f7. * Revert "ci: more logging" This reverts commit 46837f8b3ae4076e6628be3085ca895eba41af52. * Revert "ci: run all tests" This reverts commit 6a7889ce67eb3b4fa18c2c26ae86e19c7c9c44fa. * Revert "ci: more logging" This reverts commit 351473ab438b835f1a5761712aedd9dc9e4a393d. * Revert "ci: enable logging" This reverts commit 194109ed5a87392d835edfe5fd56b7237e91e209. * Revert "ci: logging" This reverts commit 9a3396fc7ab9a0d438822fe3b72f165b1e542286. * chore: disable flaky ia32 tests
This commit is contained in:
parent
a6417cc265
commit
83f15bd957
2 changed files with 15 additions and 11 deletions
|
@ -5,7 +5,6 @@ import * as Busboy from 'busboy';
|
|||
import * as path from 'node:path';
|
||||
import { ifdescribe, ifit, defer, startRemoteControlApp, repeatedly, listen } from './lib/spec-helpers';
|
||||
import { app } from 'electron/main';
|
||||
import { crashReporter } from 'electron/common';
|
||||
import { EventEmitter } from 'node:events';
|
||||
import * as fs from 'node:fs';
|
||||
import * as uuid from 'uuid';
|
||||
|
@ -583,16 +582,20 @@ ifdescribe(!isLinuxOnArm && !process.mas && !process.env.DISABLE_CRASH_REPORTER_
|
|||
});
|
||||
|
||||
describe('start() option validation', () => {
|
||||
it('requires that the submitURL option be specified', () => {
|
||||
expect(() => {
|
||||
it('requires that the submitURL option be specified', async () => {
|
||||
const { remotely } = await startRemoteControlApp();
|
||||
await expect(remotely(() => {
|
||||
const { crashReporter } = require('electron');
|
||||
crashReporter.start({} as any);
|
||||
}).to.throw('submitURL must be specified when uploadToServer is true');
|
||||
})).to.be.rejectedWith('submitURL must be specified when uploadToServer is true');
|
||||
});
|
||||
|
||||
it('allows the submitURL option to be omitted when uploadToServer is false', () => {
|
||||
expect(() => {
|
||||
it('allows the submitURL option to be omitted when uploadToServer is false', async () => {
|
||||
const { remotely } = await startRemoteControlApp();
|
||||
await expect(remotely(() => {
|
||||
const { crashReporter } = require('electron');
|
||||
crashReporter.start({ uploadToServer: false } as any);
|
||||
}).not.to.throw();
|
||||
})).to.be.fulfilled();
|
||||
});
|
||||
|
||||
it('can be called twice', async () => {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue