From 83debe2e438958b0cb4885f949639f97033b8d66 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Thu, 24 Apr 2014 12:07:03 +0800 Subject: [PATCH] Avoid passing closures to browser when showing dialog. It's resource-costy. --- atom/renderer/lib/inspector.coffee | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/atom/renderer/lib/inspector.coffee b/atom/renderer/lib/inspector.coffee index 7a07d51dc066..43a258234ffa 100644 --- a/atom/renderer/lib/inspector.coffee +++ b/atom/renderer/lib/inspector.coffee @@ -51,8 +51,8 @@ createMenu = (items, event) -> showFileChooserDialog = (callback) -> remote = require 'remote' dialog = remote.require 'dialog' - dialog.showOpenDialog remote.getCurrentWindow(), null, (files) -> - callback pathToHtml5FileObject(files[0]) if files? + files = dialog.showOpenDialog remote.getCurrentWindow(), null + callback pathToHtml5FileObject files[0] if files? pathToHtml5FileObject = (path) -> fs = require 'fs'