mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

chore: DCHECK that events are only emitted on the UI thread (#15873)

Browse source 
* chore: DCHECK that events are only emitted on the UI thread

* move dcheck to EmitWithEvent
This commit is contained in:
Jeremy Apthorp 2018-11-30 01:48:27 -08:00 committed by Cheng Zhao
parent 8483cb4aa7
commit 83d951db7e
4 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/api/event_emitter.h
View file

@ -8,6 +8,7 @@
#include <vector>
#include "atom/common/api/event_emitter_caller.h"
#include "content/public/browser/browser_thread.h"
#include "native_mate/wrappable.h"
namespace content {
@ -97,6 +98,7 @@ class EventEmitter : public Wrappable<T> {
bool EmitWithEvent(const base::StringPiece& name,
v8::Local<v8::Object> event,
const Args&... args) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate());
EmitEvent(isolate(), GetWrapper(), name, event, args...);

1
atom/browser/net/js_asker.cc
View file

@ -7,6 +7,7 @@
#include <utility>
#include "atom/common/native_mate_converters/callback.h"
#include "content/public/browser/browser_thread.h"
namespace atom {

1
atom/common/native_mate_converters/callback.cc
View file

@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "atom/common/native_mate_converters/callback.h"
#include "content/public/browser/browser_thread.h"
#include "native_mate/dictionary.h"

1
atom/common/native_mate_converters/callback.h
View file

@ -12,7 +12,6 @@
#include "base/callback.h"
#include "base/memory/weak_ptr.h"
#include "base/message_loop/message_loop.h"
#include "content/public/browser/browser_thread.h"
#include "native_mate/function_template.h"
#include "native_mate/scoped_persistent.h"