feat: promisify cookies api (#16464)
* feat: promisify the Cookie API * chore: update specs to test promisified cookies * chore: add deprecate wrapper for cookie callback API * docs: update docs to cookie promise changes * chore: remove redundant namespace use * docs: improve cookie example * docs: restore docs for cookie callback API * chore: restore cookie callback tests * fix: syntax of cookie promise return types
This commit is contained in:
parent
e2516dc808
commit
8396a2d504
8 changed files with 384 additions and 220 deletions
59
spec/fixtures/api/cookie-app/main.js
vendored
59
spec/fixtures/api/cookie-app/main.js
vendored
|
@ -3,51 +3,30 @@ const { app, session } = require('electron')
|
|||
app.on('ready', async function () {
|
||||
const url = 'http://foo.bar'
|
||||
const persistentSession = session.fromPartition('persist:ence-test')
|
||||
const name = 'test'
|
||||
const value = 'true'
|
||||
|
||||
const set = () => {
|
||||
return new Promise((resolve, reject) => {
|
||||
persistentSession.cookies.set({
|
||||
url,
|
||||
name: 'test',
|
||||
value: 'true',
|
||||
expirationDate: Date.now() + 60000
|
||||
}, error => {
|
||||
if (error) {
|
||||
reject(error)
|
||||
} else {
|
||||
resolve()
|
||||
}
|
||||
})
|
||||
})
|
||||
}
|
||||
const set = () => persistentSession.cookies.set({
|
||||
url,
|
||||
name,
|
||||
value,
|
||||
expirationDate: Date.now() + 60000
|
||||
})
|
||||
|
||||
const get = () => {
|
||||
return new Promise((resolve, reject) => {
|
||||
persistentSession.cookies.get({ url }, (error, list) => {
|
||||
if (error) {
|
||||
reject(error)
|
||||
} else {
|
||||
resolve(list)
|
||||
}
|
||||
})
|
||||
})
|
||||
}
|
||||
const get = () => persistentSession.cookies.get({
|
||||
url
|
||||
})
|
||||
|
||||
const maybeRemove = (pred) => {
|
||||
return new Promise((resolve, reject) => {
|
||||
const maybeRemove = async (pred) => new Promise(async (resolve, reject) => {
|
||||
try {
|
||||
if (pred()) {
|
||||
persistentSession.cookies.remove(url, 'test', error => {
|
||||
if (error) {
|
||||
reject(error)
|
||||
} else {
|
||||
resolve()
|
||||
}
|
||||
})
|
||||
} else {
|
||||
resolve()
|
||||
await persistentSession.cookies.remove(url, name)
|
||||
}
|
||||
})
|
||||
}
|
||||
resolve()
|
||||
} catch (error) {
|
||||
reject(error)
|
||||
}
|
||||
})
|
||||
|
||||
try {
|
||||
await maybeRemove(() => process.env.PHASE === 'one')
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue