mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: cleanup eslint suppressions (#38417)

Browse source 
* chore: cleanup eslint suppressions

* address feedback

* revert script/lib/azput.js

* revert spec/fixtures/apps/remote-control/main.js

* address feedback

* revert typings/internal-ambient.d.ts
This commit is contained in:
Milan Burda 2023-05-25 03:09:17 +02:00 • committed by GitHub
parent 1c075e5ea0
commit 82af000a37
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
34 changed files with 76 additions and 115 deletions
Download patch file Download diff file Expand all files Collapse all files

5
spec/api-browser-window-spec.ts
View file

@ -84,7 +84,6 @@ describe('BrowserWindow module', () => {
it('window does not get garbage collected when opened', async () => {
const w = new BrowserWindow({ show: false });
// Keep a weak reference to the window.
// eslint-disable-next-line no-undef
const wr = new WeakRef(w);
await setTimeout();
// Do garbage collection, since |w| is not referenced in this closure
@ -3158,15 +3157,15 @@ describe('BrowserWindow module', () => {
afterEach(closeAllWindows);
it('can be set on a window', () => {
expect(() => {
/* eslint-disable no-new */
/* eslint-disable-next-line no-new */
new BrowserWindow({
tabbingIdentifier: 'group1'
});
/* eslint-disable-next-line no-new */
new BrowserWindow({
tabbingIdentifier: 'group2',
frame: false
});
/* eslint-enable no-new */
}).not.to.throw();
});
});