Deprecate ipc module for ipcRenderer

atom/renderer/api/lib/ipc-renderer.coffee

@@ -0,0 +1,16 @@
+binding = process.atomBinding 'ipc'
+v8Util  = process.atomBinding 'v8_util'
+
+# Created by init.coffee.
+ipcRenderer = v8Util.getHiddenValue global, 'ipc'
+
+ipcRenderer.send = (args...) ->
+  binding.send 'ipc-message', [args...]
+
+ipcRenderer.sendSync = (args...) ->
+  JSON.parse binding.sendSync('ipc-message-sync', [args...])
+
+ipcRenderer.sendToHost = (args...) ->
+  binding.send 'ipc-message-host', [args...]
+
+module.exports = ipcRenderer

atom/renderer/api/lib/ipc.coffee

@@ -1,21 +1,19 @@
 deprecate = require 'deprecate'
+ipcRenderer = require 'ipc-renderer'
+{EventEmitter} = require 'events'
 
-binding = process.atomBinding 'ipc'
+# This module is deprecated, we mirror everything from ipcRenderer.
-v8Util  = process.atomBinding 'v8_util'
+deprecate.warn 'ipc module', 'ipcRenderer module'
 
-# Created by init.coffee.
+# Routes events of ipcRenderer.
-ipc = v8Util.getHiddenValue global, 'ipc'
+ipc = new EventEmitter
-
+ipcRenderer.emit = (channel, event, args...) ->
-ipc.send = (args...) ->
+  ipc.emit channel, args...
-  binding.send 'ipc-message', [args...]
+  EventEmitter::emit.apply ipcRenderer, arguments
-
-ipc.sendSync = (args...) ->
-  JSON.parse binding.sendSync('ipc-message-sync', [args...])
-
-ipc.sendToHost = (args...) ->
-  binding.send 'ipc-message-host', [args...]
 
 # Deprecated.
+for method of ipcRenderer when method.startsWith 'send'
+  ipc[method] = ipcRenderer[method]
 deprecate.rename ipc, 'sendChannel', 'send'
 deprecate.rename ipc, 'sendChannelSync', 'sendSync'
 

atom/renderer/atom_render_view_observer.cc

@@ -142,7 +142,10 @@ void AtomRenderViewObserver::OnBrowserMessage(const base::string16& channel,
 
   v8::Local<v8::Object> ipc;
   if (GetIPCObject(isolate, context, &ipc)) {
-    mate::EmitEvent(isolate, ipc, channel, ListValueToVector(isolate, args));
+    auto args_vector = ListValueToVector(isolate, args);
+    // Insert a dummy Event object.
+    args_vector.insert(args_vector.begin(), v8::Object::New(isolate));
+    mate::EmitEvent(isolate, ipc, channel, args_vector);
   }
 }
 

filenames.gypi

@@ -50,6 +50,7 @@
       'atom/renderer/lib/web-view/web-view-attributes.coffee',
       'atom/renderer/lib/web-view/web-view-constants.coffee',
       'atom/renderer/api/lib/ipc.coffee',
+      'atom/renderer/api/lib/ipc-renderer.coffee',
       'atom/renderer/api/lib/remote.coffee',
       'atom/renderer/api/lib/screen.coffee',
       'atom/renderer/api/lib/web-frame.coffee',