From 820fb3b82b6d2afbbd50f612b083a3cdeafb2255 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Mon, 5 Dec 2016 16:18:53 -0800 Subject: [PATCH] Guard against no devtools web contents --- lib/browser/api/browser-window.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/browser/api/browser-window.js b/lib/browser/api/browser-window.js index 639e54e25173..9cf1a8163cff 100644 --- a/lib/browser/api/browser-window.js +++ b/lib/browser/api/browser-window.js @@ -138,14 +138,17 @@ BrowserWindow.getFocusedWindow = () => { } BrowserWindow.fromWebContents = (webContents) => { - for (let window of BrowserWindow.getAllWindows()) { + for (const window of BrowserWindow.getAllWindows()) { if (window.webContents.equal(webContents)) return window } } BrowserWindow.fromDevToolsWebContents = (webContents) => { - for (let window of BrowserWindow.getAllWindows()) { - if (window.devToolsWebContents.equal(webContents)) return window + for (const window of BrowserWindow.getAllWindows()) { + const {devToolsWebContents} = window + if (devToolsWebContents != null && devToolsWebContents.equal(webContents)) { + return window + } } }