fix: correctly handle nexttick scheduling in stream reads (#24022)
This commit is contained in:
parent
130b176796
commit
81d09bea44
3 changed files with 47 additions and 1 deletions
|
@ -7,6 +7,7 @@ import * as http from 'http';
|
|||
import * as fs from 'fs';
|
||||
import * as qs from 'querystring';
|
||||
import * as stream from 'stream';
|
||||
import { EventEmitter } from 'events';
|
||||
import { closeWindow } from './window-helpers';
|
||||
import { emittedOnce } from './events-helpers';
|
||||
import { WebmGenerator } from './video-helpers';
|
||||
|
@ -410,6 +411,36 @@ describe('protocol module', () => {
|
|||
const r = await ajax(protocolName + '://fake-host');
|
||||
expect(r.data).to.have.lengthOf(1024 * 1024 * 2);
|
||||
});
|
||||
|
||||
it('can handle next-tick scheduling during read calls', async () => {
|
||||
const events = new EventEmitter();
|
||||
function createStream () {
|
||||
const buffers = [
|
||||
Buffer.alloc(65536),
|
||||
Buffer.alloc(65537),
|
||||
Buffer.alloc(39156)
|
||||
];
|
||||
const e = new stream.Readable({ highWaterMark: 0 });
|
||||
e.push(buffers.shift());
|
||||
e._read = function () {
|
||||
process.nextTick(() => this.push(buffers.shift() || null));
|
||||
};
|
||||
e.on('end', function () {
|
||||
events.emit('end');
|
||||
});
|
||||
return e;
|
||||
}
|
||||
registerStreamProtocol(protocolName, (request, callback) => {
|
||||
callback({
|
||||
statusCode: 200,
|
||||
headers: { 'Content-Type': 'text/plain' },
|
||||
data: createStream()
|
||||
});
|
||||
});
|
||||
const hasEndedPromise = emittedOnce(events, 'end');
|
||||
ajax(protocolName + '://fake-host');
|
||||
await hasEndedPromise;
|
||||
});
|
||||
});
|
||||
|
||||
describe('protocol.isProtocolRegistered', () => {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue