chore: remove native_mate (Part 2) (#20106)

* add notice to files being removed

* add gin version of function_template.h

* rename callback.h to avoid confliction

* add gin version of callback_converter

* add gin converter for OnceCallback

* remove callback_converter_gin_adapter.h

* remove gin_util.h and gin_utils.h

* fix lint warning

* add helper for setting methods

shell/common/api/atom_api_asar.cc

@@ -11,7 +11,7 @@
 #include "native_mate/object_template_builder.h"
 #include "native_mate/wrappable.h"
 #include "shell/common/asar/archive.h"
-#include "shell/common/native_mate_converters/callback.h"
+#include "shell/common/native_mate_converters/callback_converter_deprecated.h"
 #include "shell/common/native_mate_converters/file_path_converter.h"
 #include "shell/common/node_includes.h"
 #include "third_party/electron_node/src/node_native_module_env.h"

shell/common/api/atom_api_crash_reporter.cc

@@ -7,9 +7,9 @@
 
 #include "base/bind.h"
 #include "gin/data_object_builder.h"
-#include "gin/dictionary.h"
 #include "shell/common/crash_reporter/crash_reporter.h"
-#include "shell/common/gin_util.h"
+#include "shell/common/gin_converters/callback_converter.h"
+#include "shell/common/gin_helper/dictionary.h"
 #include "shell/common/native_mate_converters/file_path_converter.h"
 #include "shell/common/native_mate_converters/map_converter.h"
 
@@ -41,23 +41,26 @@ void Initialize(v8::Local<v8::Object> exports,
                 v8::Local<v8::Value> unused,
                 v8::Local<v8::Context> context,
                 void* priv) {
-  using gin_util::SetMethod;
   auto reporter = base::Unretained(CrashReporter::GetInstance());
-  SetMethod(exports, "start",
-            base::BindRepeating(&CrashReporter::Start, reporter));
-  SetMethod(exports, "addExtraParameter",
-            base::BindRepeating(&CrashReporter::AddExtraParameter, reporter));
-  SetMethod(
-      exports, "removeExtraParameter",
+  gin_helper::Dictionary dict(context->GetIsolate(), exports);
+  dict.SetMethod("start", base::BindRepeating(&CrashReporter::Start, reporter));
+  dict.SetMethod(
+      "addExtraParameter",
+      base::BindRepeating(&CrashReporter::AddExtraParameter, reporter));
+  dict.SetMethod(
+      "removeExtraParameter",
       base::BindRepeating(&CrashReporter::RemoveExtraParameter, reporter));
-  SetMethod(exports, "getParameters",
-            base::BindRepeating(&CrashReporter::GetParameters, reporter));
-  SetMethod(exports, "getUploadedReports",
-            base::BindRepeating(&CrashReporter::GetUploadedReports, reporter));
-  SetMethod(exports, "setUploadToServer",
-            base::BindRepeating(&CrashReporter::SetUploadToServer, reporter));
-  SetMethod(exports, "getUploadToServer",
-            base::BindRepeating(&CrashReporter::GetUploadToServer, reporter));
+  dict.SetMethod("getParameters",
+                 base::BindRepeating(&CrashReporter::GetParameters, reporter));
+  dict.SetMethod(
+      "getUploadedReports",
+      base::BindRepeating(&CrashReporter::GetUploadedReports, reporter));
+  dict.SetMethod(
+      "setUploadToServer",
+      base::BindRepeating(&CrashReporter::SetUploadToServer, reporter));
+  dict.SetMethod(
+      "getUploadToServer",
+      base::BindRepeating(&CrashReporter::GetUploadToServer, reporter));
 }
 
 }  // namespace

shell/common/api/atom_api_shell.cc

@@ -5,7 +5,7 @@
 #include <string>
 
 #include "native_mate/dictionary.h"
-#include "shell/common/native_mate_converters/callback.h"
+#include "shell/common/native_mate_converters/callback_converter_deprecated.h"
 #include "shell/common/native_mate_converters/file_path_converter.h"
 #include "shell/common/native_mate_converters/gurl_converter.h"
 #include "shell/common/native_mate_converters/string16_converter.h"

shell/common/api/gin_utils.h

@@ -1,27 +0,0 @@
-// Copyright (c) 2019 GitHub, Inc.
-// Use of this source code is governed by the MIT license that can be
-// found in the LICENSE file.
-
-#ifndef SHELL_COMMON_API_GIN_UTILS_H_
-#define SHELL_COMMON_API_GIN_UTILS_H_
-
-#include "gin/function_template.h"
-
-namespace gin {
-
-// NOTE: V8 caches FunctionTemplates. Therefore it is user's responsibility
-// to ensure this function is called for one type only ONCE in the program's
-// whole lifetime, otherwise we would have memory leak.
-template <typename Sig>
-v8::Local<v8::Function> ConvertCallbackToV8Leaked(
-    v8::Isolate* isolate,
-    const base::RepeatingCallback<Sig>& callback) {
-  // LOG(WARNING) << "Leaky conversion from callback to V8 triggered.";
-  return gin::CreateFunctionTemplate(isolate, callback)
-      ->GetFunction(isolate->GetCurrentContext())
-      .ToLocalChecked();
-}
-
-}  // namespace gin
-
-#endif  // SHELL_COMMON_API_GIN_UTILS_H_