mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

DRY up temp directory logging

Browse source
This commit is contained in:
Kevin Sawicki 2016-10-05 14:00:27 -07:00
parent 1afe501a36
commit 81733a523e
4 changed files with 8 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
atom/common/crash_reporter/crash_reporter.cc
View file

@ -36,7 +36,10 @@ void CrashReporter::Start(const std::string& product_name,
} }
bool CrashReporter::GetTempDirectory(base::FilePath* path) { bool CrashReporter::GetTempDirectory(base::FilePath* path) {
return PathService::Get(base::DIR_TEMP, path); bool success = PathService::Get(base::DIR_TEMP, path);
if (!success)
LOG(ERROR) << "Cannot get temp directory";
return success;
} }
bool CrashReporter::GetCrashesDirectory( bool CrashReporter::GetCrashesDirectory(

4
atom/common/crash_reporter/crash_reporter_linux.cc
View file

@ -79,10 +79,8 @@ void CrashReporterLinux::SetUploadParameters() {
void CrashReporterLinux::EnableCrashDumping(const std::string& product_name) { void CrashReporterLinux::EnableCrashDumping(const std::string& product_name) {
base::FilePath dumps_path; base::FilePath dumps_path;
if (!GetCrashesDirectory(&dumps_path)) { if (!GetCrashesDirectory(&dumps_path))
LOG(ERROR) << "Cannot get temp directory";
return; return;
}
base::CreateDirectory(dumps_path); base::CreateDirectory(dumps_path);

6
atom/common/crash_reporter/crash_reporter_mac.mm
View file

@ -34,15 +34,13 @@ void CrashReporterMac::InitBreakpad(const std::string& product_name,
bool auto_submit, bool auto_submit,
bool skip_system_crash_handler) { bool skip_system_crash_handler) {
// check whether crashpad has been initialized. // check whether crashpad has been initialized.
// Only need to initilize once. // Only need to initialize once.
if (simple_string_dictionary_) if (simple_string_dictionary_)
return; return;
base::FilePath database_path; base::FilePath database_path;
if (!GetCrashesDirectory(product_name, &database_path)) { if (!GetCrashesDirectory(product_name, &database_path))
LOG(ERROR) << "Cannot get temp directory";
return; return;
}
if (is_browser_) { if (is_browser_) {
@autoreleasepool { @autoreleasepool {

4
atom/common/crash_reporter/crash_reporter_win.cc
View file

@ -154,10 +154,8 @@ void CrashReporterWin::InitBreakpad(const std::string& product_name,
skip_system_crash_handler_ = skip_system_crash_handler; skip_system_crash_handler_ = skip_system_crash_handler;
base::FilePath temp_dir; base::FilePath temp_dir;
if (!GetTempDirectory(&temp_dir)) { if (!GetTempDirectory(&temp_dir))
LOG(ERROR) << "Cannot get temp directory";
return; return;
}
base::string16 pipe_name = base::ReplaceStringPlaceholders( base::string16 pipe_name = base::ReplaceStringPlaceholders(
kPipeNameFormat, base::UTF8ToUTF16(product_name), NULL); kPipeNameFormat, base::UTF8ToUTF16(product_name), NULL);