mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: disable some tests under ASan which might receive SIGKILL because of OOM (#28156)

Browse source 
* test: running child app under ASan might receive SIGKILL

* test: renderer process of webview might receive SIGKILL under ASan

* test: increase timeout for asan build
This commit is contained in:
Cheng Zhao 2021-03-17 06:02:47 +09:00 • committed by GitHub
parent 29dc5a2f83
commit 80f89a3472
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 42 additions and 76 deletions
Download patch file Download diff file Expand all files Collapse all files

11
spec-main/chromium-spec.ts
View file

@ -18,8 +18,6 @@ const features = process._linkedBinding('electron_common_features');
const fixturesPath = path.resolve(__dirname, '..', 'spec', 'fixtures');
const isAsan = process.env.IS_ASAN;
describe('reporting api', () => {
// TODO(nornagon): this started failing a lot on CI. Figure out why and fix
// it.
@ -298,7 +296,8 @@ describe('web security', () => {
});
});
describe('command line switches', () => {
// Running child app under ASan might receive SIGKILL because of OOM.
ifdescribe(!process.env.IS_ASAN)('command line switches', () => {
let appProcess: ChildProcess.ChildProcessWithoutNullStreams | undefined;
afterEach(() => {
if (appProcess && !appProcess.killed) {
@ -343,8 +342,7 @@ describe('command line switches', () => {
ifit(process.platform === 'linux')('should not change LC_ALL when --lang is not set', async () => testLocale('', lcAll, true));
});
// TODO(nornagon): figure out why these tests fail under ASan.
ifdescribe(!isAsan)('--remote-debugging-pipe switch', () => {
describe('--remote-debugging-pipe switch', () => {
it('should expose CDP via pipe', async () => {
const electronPath = process.execPath;
appProcess = ChildProcess.spawn(electronPath, ['--remote-debugging-pipe'], {
@ -386,8 +384,7 @@ describe('command line switches', () => {
});
});
// TODO(nornagon): figure out why these tests fail under ASan.
ifdescribe(!isAsan)('--remote-debugging-port switch', () => {
describe('--remote-debugging-port switch', () => {
it('should display the discovery page', (done) => {
const electronPath = process.execPath;
let output = '';