From 8075a55815d3b44f202525babbffb1f19d1a17b2 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 10 Mar 2020 11:13:41 +0900 Subject: [PATCH] test: disable spellchecker context menu test for arm (#22590) --- spec-main/spellchecker-spec.ts | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/spec-main/spellchecker-spec.ts b/spec-main/spellchecker-spec.ts index 81f14f8c7110..8af3fbc26d61 100644 --- a/spec-main/spellchecker-spec.ts +++ b/spec-main/spellchecker-spec.ts @@ -20,15 +20,18 @@ describe('spellchecker', () => { await closeWindow(w) }) - // Spellchecker loads slow on ARM CI machines. - const waitTime = (process.arch === 'arm' || process.arch === 'arm64') ? 2000 : 500 + // Context menu test can not run on Windows, and it is not reliable on ARM + // CI machines. + const shouldRun = process.platform !== 'win32' && + process.arch !== 'arm' && + process.arch !== 'arm64' - ifit(process.platform !== 'win32')('should detect correctly spelled words as correct', async () => { + ifit(shouldRun)('should detect correctly spelled words as correct', async () => { await w.webContents.executeJavaScript('document.body.querySelector("textarea").value = "Beautiful and lovely"') await w.webContents.executeJavaScript('document.body.querySelector("textarea").focus()') const contextMenuPromise = emittedOnce(w.webContents, 'context-menu') // Wait for spellchecker to load - await new Promise(resolve => setTimeout(resolve, waitTime)) + await new Promise(resolve => setTimeout(resolve, 500)) w.webContents.sendInputEvent({ type: 'mouseDown', button: 'right', @@ -40,12 +43,12 @@ describe('spellchecker', () => { expect(contextMenuParams.dictionarySuggestions).to.have.lengthOf(0) }) - ifit(process.platform !== 'win32')('should detect incorrectly spelled words as incorrect', async () => { + ifit(shouldRun)('should detect incorrectly spelled words as incorrect', async () => { await w.webContents.executeJavaScript('document.body.querySelector("textarea").value = "Beautifulllll asd asd"') await w.webContents.executeJavaScript('document.body.querySelector("textarea").focus()') const contextMenuPromise = emittedOnce(w.webContents, 'context-menu') // Wait for spellchecker to load - await new Promise(resolve => setTimeout(resolve, waitTime)) + await new Promise(resolve => setTimeout(resolve, 500)) w.webContents.sendInputEvent({ type: 'mouseDown', button: 'right',