mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: lint Objective-C header files (#31923)

Browse source
This commit is contained in:
Milan Burda 2021-11-22 01:36:32 +01:00 • committed by GitHub
parent 98a5996b30
commit 7ff15038d6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 15 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

8
script/lint.js
View file

@ -14,10 +14,6 @@ const DEPOT_TOOLS = path.resolve(SOURCE_ROOT, '..', 'third_party', 'depot_tools'
const IGNORELIST = new Set([
['shell', 'browser', 'resources', 'win', 'resource.h'],
['shell', 'browser', 'notifications', 'mac', 'notification_center_delegate.h'],
['shell', 'browser', 'ui', 'cocoa', 'event_dispatching_window.h'],
['shell', 'browser', 'ui', 'cocoa', 'NSColor+Hex.h'],
['shell', 'browser', 'ui', 'cocoa', 'NSString+ANSI.h'],
['shell', 'common', 'node_includes.h'],
['spec', 'static', 'jquery-2.0.3.min.js'],
['spec', 'ts-smoke', 'electron', 'main.ts'],
@ -82,7 +78,7 @@ const LINTERS = [{
}, {
key: 'objc',
roots: ['shell'],
test: filename => filename.endsWith('.mm'),
test: filename => filename.endsWith('.mm') || (filename.endsWith('.h') && isObjCHeader(filename)),
run: (opts, filenames) => {
if (opts.fix) {
spawnAndCheckExitCode('python', ['script/run-clang-format.py', '--fix', ...filenames]);
@ -96,7 +92,7 @@ const LINTERS = [{
'-whitespace/indent',
'-whitespace/parens'
];
cpplint(['--extensions=mm', `--filter=${filter.join(',')}`, ...filenames]);
cpplint(['--extensions=mm,h', `--filter=${filter.join(',')}`, ...filenames]);
}
}, {
key: 'python',