mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Revert "build: enable PIE when compiling Linux builds, fix #14961. (#15152)"

Browse source 
This reverts commit 70d4644742.
This commit is contained in:
Samuel Attard 2018-10-18 14:09:34 +11:00
parent 1d79840025
commit 7fb6b3bda8
3 changed files with 0 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
brightray/brightray.gyp
View file

@ -84,8 +84,6 @@
}, },
'cflags': [ 'cflags': [
'<!@(<(pkg-config) --cflags <(linux_system_libraries))', '<!@(<(pkg-config) --cflags <(linux_system_libraries))',
# Needed for PIE
'-fPIC',
], ],
'direct_dependent_settings': { 'direct_dependent_settings': {
'cflags': [ 'cflags': [

1
common.gypi
View file

@ -263,7 +263,6 @@
['OS=="linux"', { ['OS=="linux"', {
'cflags': [ 'cflags': [
'-Wno-empty-body', '-Wno-empty-body',
'-fPIC',
], ],
}], # OS=="linux" }], # OS=="linux"
['OS=="win"', { ['OS=="win"', {

11
electron.gyp
View file

@ -253,16 +253,6 @@
], ],
}, },
], ],
'link_settings': {
'ldflags': [
# Build as Position-Independent Executable to mitigate exploitations.
'-pie',
],
},
'cflags_cc': [
# Needed for PIE
'-fPIC',
]
}], # OS=="linux" }], # OS=="linux"
], ],
}, # target <(project_name) }, # target <(project_name)
@ -451,7 +441,6 @@
# Required settings of using breakpad. # Required settings of using breakpad.
'cflags_cc': [ 'cflags_cc': [
'-Wno-empty-body', '-Wno-empty-body',
'-fPIC',
], ],
'include_dirs': [ 'include_dirs': [
'vendor/breakpad/src', 'vendor/breakpad/src',