From 7f885bd266b525053b8708786e56023bab4e7b9d Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Mon, 14 Sep 2020 12:22:13 -0500 Subject: [PATCH] chore: remove unused code from our js scripts (#25419) --- script/doc-only-change.js | 2 -- script/node-spec-runner.js | 2 -- script/release/ci-release-build.js | 1 - script/release/release-artifact-cleanup.js | 1 - script/spec-runner.js | 1 - spec/static/main.js | 2 +- 6 files changed, 1 insertion(+), 8 deletions(-) diff --git a/script/doc-only-change.js b/script/doc-only-change.js index 4d692a73309f..2a686752fa65 100644 --- a/script/doc-only-change.js +++ b/script/doc-only-change.js @@ -3,8 +3,6 @@ const { Octokit } = require('@octokit/rest'); const octokit = new Octokit(); const path = require('path'); -const SOURCE_ROOT = path.normalize(path.dirname(__dirname)); - async function checkIfDocOnlyChange () { if (args.prNumber || args.prBranch || args.prURL) { try { diff --git a/script/node-spec-runner.js b/script/node-spec-runner.js index a81d4ec65d7a..340ff1d9f63b 100644 --- a/script/node-spec-runner.js +++ b/script/node-spec-runner.js @@ -10,12 +10,10 @@ const args = require('minimist')(process.argv.slice(2), { const BASE = path.resolve(__dirname, '../..'); const DISABLED_TESTS = require('./node-disabled-tests.json'); const NODE_DIR = path.resolve(BASE, 'third_party', 'electron_node'); -const NPX_CMD = process.platform === 'win32' ? 'npx.cmd' : 'npx'; const JUNIT_DIR = args.jUnitDir ? path.resolve(args.jUnitDir) : null; const TAP_FILE_NAME = 'test.tap'; const utils = require('./lib/utils'); -const { YARN_VERSION } = require('./yarn'); if (!process.mainModule) { throw new Error('Must call the node spec runner directly'); diff --git a/script/release/ci-release-build.js b/script/release/ci-release-build.js index 511fe7cb5b36..df171bc9db4c 100644 --- a/script/release/ci-release-build.js +++ b/script/release/ci-release-build.js @@ -91,7 +91,6 @@ async function circleCIcall (targetBranch, job, options) { try { const circleResponse = await circleCIRequest(CIRCLECI_PIPELINE_URL, 'POST', buildRequest); console.log(`CircleCI release build pipeline ${circleResponse.id} for ${job} triggered.`); - const pipelineInfoUrl = `https://circleci.com/api/v2/pipeline/${circleResponse.id}`; const workflowId = await getCircleCIWorkflowId(circleResponse.id); if (workflowId === -1) { return; diff --git a/script/release/release-artifact-cleanup.js b/script/release/release-artifact-cleanup.js index d129207f3fef..1c4d70e9352c 100755 --- a/script/release/release-artifact-cleanup.js +++ b/script/release/release-artifact-cleanup.js @@ -5,7 +5,6 @@ const args = require('minimist')(process.argv.slice(2), { string: ['tag', 'releaseID'], default: { releaseID: '' } }); -const path = require('path'); const { execSync } = require('child_process'); const { GitProcess } = require('dugite'); const { getCurrentBranch, ELECTRON_DIR } = require('../lib/utils.js'); diff --git a/script/spec-runner.js b/script/spec-runner.js index 8e557136f9a4..10c478cb6c83 100755 --- a/script/spec-runner.js +++ b/script/spec-runner.js @@ -30,7 +30,6 @@ const utils = require('./lib/utils'); const { YARN_VERSION } = require('./yarn'); const BASE = path.resolve(__dirname, '../..'); -const NPM_CMD = process.platform === 'win32' ? 'npm.cmd' : 'npm'; const NPX_CMD = process.platform === 'win32' ? 'npx.cmd' : 'npx'; const runners = new Map([ diff --git a/spec/static/main.js b/spec/static/main.js index acf54b609d9a..ff9469ae18e6 100644 --- a/spec/static/main.js +++ b/spec/static/main.js @@ -2,7 +2,7 @@ process.throwDeprecation = false; const electron = require('electron'); -const { app, BrowserWindow, crashReporter, dialog, ipcMain, protocol, webContents, session } = electron; +const { app, BrowserWindow, dialog, ipcMain, protocol, webContents, session } = electron; try { require('fs').rmdirSync(app.getPath('userData'), { recursive: true });