From 7f605c8442244297fd3a8072ce17e7ec50160199 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Mon, 3 Jun 2013 17:58:34 +0800 Subject: [PATCH] Fix crashes in auto updater. --- browser/auto_updater_mac.mm | 7 +------ browser/mac/Info.plist | 2 ++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/browser/auto_updater_mac.mm b/browser/auto_updater_mac.mm index 880e7967e4fb..8837f5387a18 100644 --- a/browser/auto_updater_mac.mm +++ b/browser/auto_updater_mac.mm @@ -56,10 +56,6 @@ void CallNSInvocation(ScopedNSInvocation invocation) { base::Bind(&CallNSInvocation, base::Passed(invocation_ptr.Pass()))); } -- (void)updaterWillRelaunchApplication:(SUUpdater*)updater { - [[SUUpdater sharedUpdater] setDelegate:nil]; -} - @end namespace auto_updater { @@ -67,7 +63,6 @@ namespace auto_updater { // static void AutoUpdater::Init() { SUUpdaterDelegate* delegate = [[SUUpdaterDelegate alloc] init]; - [delegate autorelease]; [[SUUpdater sharedUpdater] setDelegate:delegate]; } @@ -89,7 +84,7 @@ void AutoUpdater::SetAutomaticallyDownloadsUpdates(bool yes) { // static void AutoUpdater::CheckForUpdates() { - [[SUUpdater sharedUpdater] checkForUpdates:[SUUpdater sharedUpdater]]; + [[SUUpdater sharedUpdater] checkForUpdates:nil]; } // static diff --git a/browser/mac/Info.plist b/browser/mac/Info.plist index 07bc63281af4..971fd379af0a 100644 --- a/browser/mac/Info.plist +++ b/browser/mac/Info.plist @@ -8,6 +8,8 @@ ${PRODUCT_NAME} CFBundleIconFile atom.icns + CFBundleVersion + 1.0 NSMainNibFile MainMenu NSPrincipalClass