mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: add missing enable_view_api flag (#14351)

Browse source 
* build: add missing enable_view_api flag

Fixes #14340.

* fix: properly pass a pointer to a SetLayoutManager() call
This commit is contained in:
Alexey Kuzmin 2018-08-28 19:55:31 +02:00 • committed by Shelley Vohr
parent 07d017dc01
commit 7edd37bca1
2 changed files with 30 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/browser/api/atom_api_view.cc
View file

@ -26,9 +26,7 @@ View::~View() {
#if defined(ENABLE_VIEW_API)
void View::SetLayoutManager(mate::Handle<LayoutManager> layout_manager) {
layout_manager_.Reset(isolate(), layout_manager->GetWrapper());
// TODO(zcbenz): New versions of Chrome takes std::unique_ptr instead of raw
// pointer, remove the "release()" call when we upgraded to it.
view()->SetLayoutManager(layout_manager->TakeOver().release());
view()->SetLayoutManager(layout_manager->TakeOver());
}
void View::AddChildView(mate::Handle<View> child) {