From 7ed3c7a359c78c725ba02eaf5edd28968e356a32 Mon Sep 17 00:00:00 2001
From: Milan Burda <milan.burda@gmail.com>
Date: Mon, 20 Mar 2023 15:26:42 +0100
Subject: [PATCH] chore: remove unnecessary casting to base::Value (#37591)

Co-authored-by: Milan Burda <miburda@microsoft.com>
---
 shell/browser/api/electron_api_debugger.cc    | 4 ++--
 shell/browser/api/electron_api_web_request.cc | 3 +--
 shell/browser/ui/inspectable_web_contents.cc  | 2 +-
 shell/browser/ui/webui/accessibility_ui.cc    | 4 ++--
 shell/common/gin_converters/net_converter.cc  | 2 +-
 5 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/shell/browser/api/electron_api_debugger.cc b/shell/browser/api/electron_api_debugger.cc
index 0a9e88630a03..0aaa71a2891d 100755
--- a/shell/browser/api/electron_api_debugger.cc
+++ b/shell/browser/api/electron_api_debugger.cc
@@ -153,7 +153,7 @@ v8::Local<v8::Promise> Debugger::SendCommand(gin::Arguments* args) {
   request.Set("id", request_id);
   request.Set("method", method);
   if (!command_params.empty()) {
-    request.Set("params", base::Value(std::move(command_params)));
+    request.Set("params", std::move(command_params));
   }
 
   if (!session_id.empty()) {
@@ -161,7 +161,7 @@ v8::Local<v8::Promise> Debugger::SendCommand(gin::Arguments* args) {
   }
 
   std::string json_args;
-  base::JSONWriter::Write(base::Value(std::move(request)), &json_args);
+  base::JSONWriter::Write(request, &json_args);
   agent_host_->DispatchProtocolMessage(
       this, base::as_bytes(base::make_span(json_args)));
 
diff --git a/shell/browser/api/electron_api_web_request.cc b/shell/browser/api/electron_api_web_request.cc
index 428b9d8aa584..0e3b4ae622e8 100644
--- a/shell/browser/api/electron_api_web_request.cc
+++ b/shell/browser/api/electron_api_web_request.cc
@@ -159,8 +159,7 @@ v8::Local<v8::Value> HttpResponseHeadersToV8(
       values->Append(base::Value(value));
     }
   }
-  return gin::ConvertToV8(v8::Isolate::GetCurrent(),
-                          base::Value(std::move(response_headers)));
+  return gin::ConvertToV8(v8::Isolate::GetCurrent(), response_headers);
 }
 
 // Overloaded by multiple types to fill the |details| object.
diff --git a/shell/browser/ui/inspectable_web_contents.cc b/shell/browser/ui/inspectable_web_contents.cc
index 6a0afd12e966..5549a6ff0e63 100644
--- a/shell/browser/ui/inspectable_web_contents.cc
+++ b/shell/browser/ui/inspectable_web_contents.cc
@@ -623,7 +623,7 @@ void InspectableWebContents::AddDevToolsExtensionsToClient() {
     extension_info.Set("exposeExperimentalAPIs",
                        extension->permissions_data()->HasAPIPermission(
                            extensions::mojom::APIPermissionID::kExperimental));
-    results.Append(base::Value(std::move(extension_info)));
+    results.Append(std::move(extension_info));
   }
 
   CallClientFunction("DevToolsAPI", "addExtensions",
diff --git a/shell/browser/ui/webui/accessibility_ui.cc b/shell/browser/ui/webui/accessibility_ui.cc
index b5b9de2d5ec5..e086ce289f4f 100644
--- a/shell/browser/ui/webui/accessibility_ui.cc
+++ b/shell/browser/ui/webui/accessibility_ui.cc
@@ -282,7 +282,7 @@ void HandleAccessibilityRequestCallback(
     descriptor.Set(kNative, is_native_enabled);
     descriptor.Set(kWeb, is_web_enabled);
     descriptor.Set(kLabelImages, are_accessibility_image_labels_enabled);
-    rvh_list.Append(base::Value(std::move(descriptor)));
+    rvh_list.Append(std::move(descriptor));
   }
 
   data.Set(kPagesField, std::move(rvh_list));
@@ -295,7 +295,7 @@ void HandleAccessibilityRequestCallback(
   data.Set(kBrowsersField, std::move(window_list));
 
   std::string json_string;
-  base::JSONWriter::Write(base::Value(std::move(data)), &json_string);
+  base::JSONWriter::Write(data, &json_string);
 
   std::move(callback).Run(
       base::MakeRefCounted<base::RefCountedString>(std::move(json_string)));
diff --git a/shell/common/gin_converters/net_converter.cc b/shell/common/gin_converters/net_converter.cc
index 687d7610a8be..fe63063c3b11 100644
--- a/shell/common/gin_converters/net_converter.cc
+++ b/shell/common/gin_converters/net_converter.cc
@@ -166,7 +166,7 @@ v8::Local<v8::Value> Converter<net::HttpResponseHeaders*>::ToV8(
       values->Append(value);
     }
   }
-  return ConvertToV8(isolate, base::Value(std::move(response_headers)));
+  return ConvertToV8(isolate, response_headers);
 }
 
 bool Converter<net::HttpResponseHeaders*>::FromV8(